fix build

Author: TheCodingLand

.github/workflows/build.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Python 3.12
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v5
         with:
           python-version: "3.12"
 
@@ -37,7 +37,7 @@ jobs:
           Compress-Archive -Path .\dist\* -DestinationPath windows-dist.zip
 
       - name: Upload Windows Build Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: windows-dist
           path: windows-dist.zip
@@ -49,7 +49,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Python 3.12
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v5
         with:
           python-version: "3.12"
 
@@ -68,7 +68,7 @@ jobs:
           zip -r linux-dist.zip dist/
 
       - name: Upload Linux Build Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: linux-dist
           path: linux-dist.zip
@@ -82,13 +82,13 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Download Windows Build Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: windows-dist
           path: .
 
       - name: Download Linux Build Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: linux-dist
           path: .

.github/workflows/test.yml

@@ -24,7 +24,7 @@ jobs:
           fetch-depth: 0  # Needed for committing changes
 
       - name: Set up Python 3.12
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v5
         with:
           python-version: "3.12"
       - name: Install system dependencies
@@ -57,6 +57,13 @@ jobs:
       - name: Generate coverage badge
         uses: tj-actions/coverage-badge-py@v2
 
+      - name: Check for coverage badge changes
+        id: verify-changed-files
+        uses: tj-actions/verify-changed-files@v16
+        with:
+          files: |
+            coverage.svg
+
       - name: Commit files
         if: steps.verify-changed-files.outputs.files_changed == 'true'
         run: |

app/ui.py

@@ -423,6 +423,8 @@ def _update_unsupported_actions_label(self) -> None:
             self.unsupported_actions_label.setStyleSheet("color: #666666;")
 
     def update_validation_status_indicator(self, report: Optional[ValidationReport]) -> None:
+        self.binding_validation_report = report
+
         if report is None:
             self.validation_status_label.setText("Binding status: Not evaluated")
             self.validation_status_label.setStyleSheet("color: #666666;")
@@ -883,7 +885,6 @@ def update_control_map(self) -> None:
         desired_profile = self.build_control_profile_snapshot()
         plan = self.binding_planner.plan_from_profile(desired_profile)
         report = self.binding_planner.validate_plan(plan)
-        self.binding_validation_report = report
         self._log_binding_validation_report(report)
 
         for binding in plan.to_remove:

ci.yml

@@ -14,16 +14,16 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: ./test.yml
+      - uses: ./.github/workflows/test.yml
 
   build-windows:
     needs: test
     runs-on: windows-latest
     steps:
-      - uses: ./build.yml
+      - uses: ./.github/workflows/build.yml
 
   build-linux:
     needs: test
     runs-on: ubuntu-latest
     steps:
-      - uses: ./build.yml
+      - uses: ./.github/workflows/build.yml

tests/test_ui.py

@@ -318,15 +318,18 @@ def test_unsupported_actions_label_updates(main_window: ControlMapperApp) -> Non
 def test_validation_status_label(main_window: ControlMapperApp) -> None:
     """Validation status label reflects report severity."""
     main_window.update_validation_status_indicator(None)
+    assert main_window.binding_validation_report is None
     assert main_window.validation_status_label.text() == "Binding status: Not evaluated"
 
     report = ValidationReport()
     report.add(ValidationIssue(level="warning", message="example warning"))
     main_window.update_validation_status_indicator(report)
+    assert main_window.binding_validation_report is report
     assert main_window.validation_status_label.text() == "Binding status: 1 warning(s)"
 
     report = ValidationReport()
     report.add(ValidationIssue(level="error", message="example error"))
     report.add(ValidationIssue(level="ERROR", message="another"))
     main_window.update_validation_status_indicator(report)
+    assert main_window.binding_validation_report is report
     assert main_window.validation_status_label.text() == "Binding status: 2 error(s)"

todo.md

@@ -4,7 +4,8 @@
 - [x] Exercise the new `uv` workflow (`uv sync`, `uv run`). _Next:_ remove or document `requirements.txt` deprecation.
 - [x] Capture locking/release strategy (e.g. `uv lock`) and wire it into CI. `uv.lock` now checked in; add CI step later.
 - [ ] Validate the Nuitka build script on Windows and produce a distributable artifact. *(Blocked pending service/domain refactor.)*
-- [ ] Decide whether the Nuitka build should be `onefile` or directory based for faster launches.
+- [ ] the Nuitka build should be `onefile`
+- [x] fix github actions errors This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`
 - [ ] Add packaging docs to `README.md` once the build path is confirmed.
 
 ## Codebase Cleanup