Skip to content

Commit 4d31e68

Browse files
author
TheCodingSheikh
committed
feat(kubeflow): add common app annotation
1 parent 519e975 commit 4d31e68

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

charts/kubeflow/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ description: >
55
preconfigured according to the upstream examples/kustomization.yaml structure.
66
77
type: application
8-
version: 1.0.0
8+
version: 1.0.1
99
appVersion: "1.10.0"
1010

1111
home: https://github.com/TheCodingSheikh/helm-charts/tree/main/charts/kubeflow

charts/kubeflow/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ argoProjectName: kubeflow
2929
# Namespace where ArgoCD is installed
3030
argoNamespace: argocd
3131

32+
# Common annotations for all argo apps
33+
commonAppAnnotations: {}
34+
3235
# Destination Kubernetes cluster ArgoCD will deploy to
3336
destinationServer: https://kubernetes.default.svc
3437

charts/kubeflow/templates/application.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ metadata:
1212
labels:
1313
{{ toYaml $config.labels | indent 4 }}
1414
{{- end }}
15-
{{- if $config.annotations }}
16-
annotations:
17-
{{ toYaml $config.annotations | indent 4 }}
18-
{{- end }}
15+
{{- $annotations := merge ($root.Values.commonAppAnnotations | default (dict)) ($config.annotations | default (dict)) }}
16+
{{- if $annotations }}
17+
annotations:
18+
{{ toYaml $annotations | indent 4 }}
19+
{{- end }}
1920
spec:
2021
project: {{ $root.Values.argoProjectName }}
2122
source:
@@ -48,7 +49,6 @@ spec:
4849
syncOptions:
4950
- ApplyOutOfSyncOnly=true
5051
- ServerSideApply=true
51-
5252
{{- end }}
5353
{{- end }}
5454
{{- end }}

charts/kubeflow/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
argoProjectName: kubeflow
22
argoNamespace: argocd
3+
commonAppAnnotations: {}
34
destinationServer: https://kubernetes.default.svc
45
kubeflowManifestsRepo: https://github.com/kubeflow/manifests
56
kubeflowManifestsRepoBranch: HEAD

0 commit comments

Comments
 (0)