Get the tests to work...

When evaluating the tests on my personal machine, I noticed that the test_main_application_window hung, so now I force it to exit.

Also realized that I messed up the variable input arguments.

Author: AdvancedImagingUTSW

README.md

@@ -11,7 +11,8 @@ navigate
 [![Tests](https://github.com/TheDeanLab/navigate/actions/workflows/push_checks.yaml/badge.svg)](https://github.com/TheDeanLab/navigate/actions/workflows/push_checks.yaml)
 [![codecov](https://codecov.io/gh/TheDeanLab/navigate/branch/develop/graph/badge.svg?token=270RFSZGG5)](https://codecov.io/gh/TheDeanLab/navigate)
 
-Navigate is an open source Python package for control of light-sheet microscopes. It allows for easily reconfigurable hardware setups and automated acquisition rotuines.
+**navigate** is an open source Python package for control of light-sheet microscopes.
+It allows for easily reconfigurable hardware setups and automated acquisition rotuines.
 
 ### Quick install
 

src/navigate/tools/main_functions.py

@@ -101,7 +101,7 @@ def evaluate_parser_input_arguments(args):
         ), "experiment_file file Path {} not valid".format(args.experiment_file)
         experiment_path = args.experiment_file
 
-    if args.waveform_constants_path:
+    if args.waveform_constants_file:
         assert (
             args.waveform_constants_path.exists()
         ), "waveform_constants_path Path {} not valid".format(

test/controller/test_controller.py

@@ -27,6 +27,9 @@ def controller(tk_root):
     waveform_templates_path = Path.joinpath(
         configuration_directory, "waveform_templates.yml"
     )
+    gui_configuration_path = Path.joinpath(
+        configuration_directory, "gui_configuration.yml"
+    )
     args = SimpleNamespace(synthetic_hardware=True)
 
     controller = Controller(
@@ -37,6 +40,7 @@ def controller(tk_root):
         waveform_constants_path,
         rest_api_path,
         waveform_templates_path,
+        gui_configuration_path,
         args,
     )
     # To make sure the testcases won't hang on because of the model.event_queue

test/test_main.py

@@ -58,9 +58,10 @@ def test_argument_parser(self):
         input_arguments = [
             "--config-file",
             "--experiment-file",
-            "--waveform-constants-path",
+            "--waveform-constants-file",
             "--rest-api-file",
             "--logging-config",
+            "--gui-config-file",
         ]
         for arg in input_arguments:
             parser.parse_args([arg, str(Path.joinpath(navigate_path, "test.yml"))])

test/view/test_main_application_window.py

@@ -78,18 +78,18 @@ def setUp(self):
         # Create a root Tkinter window for testing
         self.root = tk.Tk()
 
-    def tearDown(self):
-        # Destroy the root window after each test
-        self.root.destroy()
-
     @patch(
         target="navigate.view.main_application_window.Path.joinpath",
         side_effect=tk.TclError,
     )
-    @patch(target="navigate.view.main_application_window.SettingsNotebook", autospec=True)
+    @patch(
+        target="navigate.view.main_application_window.SettingsNotebook", autospec=True
+    )
     def test_main_app_with_patched_joinpath(
         self, mock_settings_notebook, mock_joinpath
     ):
         # Create an instance of main_application_window
         MainApp(self.root)
         self.root.update()
+        self.root.destroy()
+        pass