Code review

Looked over all changes with @joelaugustine099

Co-Authored-By: Joel Augustine <[email protected]>

Author: AdvancedImagingUTSW

src/navigate/model/device_startup_functions.py

@@ -513,7 +513,9 @@ def start_device(
     device_not_found(microscope_name, device_category, device_type, device_id)
 
 
-def start_daq(configuration: Dict[str, Any], device_type: str = "NI", name: str = "name") -> DAQBase:
+def start_daq(
+    configuration: Dict[str, Any], device_type: str = "NI", name: str = "name"
+) -> DAQBase:
     """Initializes the data acquisition (DAQ) class on a dedicated thread.
 
     Load daq information from the configuration file. Proper daq types include NI and
@@ -583,9 +585,9 @@ def device_not_found(*args: Any) -> None:
 def load_devices(
     microscope_name: str,
     configuration: Dict[str, Any],
-    is_synthetic=False,
-    devices_dict={},
-    plugin_devices=None,
+    is_synthetic: bool = False,
+    devices_dict: dict = {},
+    plugin_devices: Optional[dict] = None,
 ) -> dict:
     """Load devices from configuration.
 
@@ -597,6 +599,8 @@ def load_devices(
         Configuration dictionary
     is_synthetic : bool
         Run synthetic version of hardware?
+    devices_dict : dict
+        Dictionary of devices to load
     plugin_devices : dict
         Dictionary of plugin devices
 
@@ -620,8 +624,10 @@ def load_devices(
         ]["hardware"]["type"]
 
     if device_type not in devices_dict["daq"]:
-        if (device_type == "asi.ASI"):
-            devices_dict["daq"][device_type] = start_daq(configuration, device_type, microscope_name)
+        if device_type == "asi.ASI":
+            devices_dict["daq"][device_type] = start_daq(
+                configuration, device_type, microscope_name
+            )
         else:
             devices_dict["daq"][device_type] = start_daq(configuration, device_type)