Skip to content

Conversation

@V-Francois
Copy link
Contributor

Summary

This PR introduces a validation test, which aims at testing the physical results of the code as a whole, rather than independent bits of the code (usually handled by unit tests).

This tests runs a binary mixture of LJ particles, at different conditions, and compares results to published data.
It validates that the overall MC algorithm, the displacement move, and the LJ model are properly implemented.

@V-Francois
Copy link
Contributor Author

@romainljsimon , @leonardogalliano : I mostly did that as a tutorial for myself to learn about the codebase in a "hands-on" fashion.
Feel free to dismiss if you think it shouldn't be part of the main repo.

I personally like to include these validation tests in repos, as it gives more thorough examples to potential users, and can serve as non regression tests/long tests when doing major changes.

@romainljsimon romainljsimon self-requested a review January 15, 2026 11:18
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romainljsimon
Copy link
Member

@V-Francois I think it's a great idea but I'm not sure if you want or not this to be part of CI/CD

@V-Francois
Copy link
Contributor Author

@V-Francois I think it's a great idea but I'm not sure if you want or not this to be part of CI/CD

No. It takes a lot of time to run, and currently there's not actual check, I just did a visual look at the plot.

@romainljsimon romainljsimon merged commit a86cd1b into TheDisorderedOrganization:main Jan 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants