Merge pull request #90

[4.x] Fixed handling of comparison of mixed parameter names

Author: andrey-helldar

src/Benchmark.php

@@ -18,7 +18,6 @@
 use function abs;
 use function array_first;
 use function count;
-use function func_get_args;
 use function is_array;
 use function is_callable;
 use function max;
@@ -103,12 +102,10 @@ public function round(?int $precision): static
 
     public function compare(array|Closure ...$callbacks): static
     {
-        $values = $this->resolveCallbacks(
-            func_get_args() ?: $callbacks
-        );
-
         $this->clear();
 
+        $values = $this->resolveCallbacks($callbacks);
+
         $this->withProgress($values, $this->steps($values));
 
         return $this;

tests/Unit/Compares/AsArrayTest.php

@@ -27,3 +27,17 @@
         1,
     ]);
 });
+
+test('mixed names', function () {
+    $results = benchmark(false)->compare([
+        static fn () => true,
+        'foo' => static fn () => true,
+        'bar' => static fn () => false,
+    ])->toData();
+
+    expect($results)->toHaveKeys([
+        0,
+        'foo',
+        'bar',
+    ]);
+});

tests/Unit/Compares/AsCallbackTest.php

@@ -27,3 +27,17 @@
         1,
     ]);
 });
+
+test('mixed names', function () {
+    $results = benchmark(false)->compare(
+        static fn () => true,
+        foo: static fn () => true,
+        bar: static fn () => false,
+    )->toData();
+
+    expect($results)->toHaveKeys([
+        0,
+        'foo',
+        'bar',
+    ]);
+});