fix(middleware): set success to false for navigation events

Author: TheEdoRan

packages/next-safe-action/src/__tests__/middleware.test.ts

@@ -342,11 +342,11 @@ test("framework error result from middleware is correct", async () => {
 	});
 
 	const expectedResult = {
-		success: true,
+		success: false,
 		ctx: {
 			foo: "bar",
 		},
-		data: undefined,
+		navigationKind: "redirect",
 		parsedInput: {
 			username: "johndoe",
 		},

packages/next-safe-action/src/action-builder.ts

@@ -120,7 +120,15 @@ export function actionBuilder<
 										await executeMiddlewareStack(idx + 1);
 										return middlewareResult;
 									},
-								}).catch((e) => frameworkErrorHandler.handleError(e));
+								}).catch((e) => {
+									frameworkErrorHandler.handleError(e);
+									if (frameworkErrorHandler.error) {
+										middlewareResult.success = false;
+										middlewareResult.navigationKind = FrameworkErrorHandler.getNavigationKind(
+											frameworkErrorHandler.error
+										);
+									}
+								});
 								// Action function.
 							} else {
 								// Validate the client inputs in parallel.
@@ -220,8 +228,16 @@ export function actionBuilder<
 									}
 								}
 
-								middlewareResult.success = true;
-								middlewareResult.data = data;
+								if (frameworkErrorHandler.error) {
+									middlewareResult.success = false;
+									middlewareResult.navigationKind = FrameworkErrorHandler.getNavigationKind(
+										frameworkErrorHandler.error
+									);
+								} else {
+									middlewareResult.success = true;
+									middlewareResult.data = data;
+								}
+
 								middlewareResult.parsedInput = parsedInputDatas.at(-1);
 								middlewareResult.bindArgsParsedInputs = parsedInputDatas.slice(0, -1);
 							}

packages/next-safe-action/src/index.types.ts

@@ -131,6 +131,7 @@ export type MiddlewareResult<ServerError, NextCtx extends object> = SafeActionRe
 	any,
 	NextCtx
 > & {
+	navigationKind?: NavigationKind;
 	parsedInput?: unknown;
 	bindArgsParsedInputs?: unknown[];
 	ctx?: object;