After finishing the paragraph, the test does not finish

[MadhavBahl]

We should stop the timer as soon as we complete the test, would have to change the score calculation logic accordingly

Should be a very simple fix, labeling it as good-first-issue

[Divyansh0811]

Hello sir, I would like to work on this issue can you guide me?
My logic: Just like we checked for overflow case, here in this case
if (index === this.state.selectedParagraph.length - 1) {
this.setState({
characters,
words,
timeRemaining: 0,
});
return;
}

[MadhavBahl]

Hahaha, no need to say sorry for that, It's a general convention/ethic in the world of open source to put a comment on the open issue that "I want to work on this" and then wait for the author to assign that issue to you, This avoids duplicate efforts - imagine two people willing to work on the same issue, and instead of waiting for issue to be assigned, they both raise a PR - it will be duplicate efforts since only 1 pr will go in. But, in this issue, you were the only one who made that comment, so it's ok :)

…

On Mon, Jun 14, 2021 at 8:26 PM Divyansh0811 ***@***.***> wrote: Sorry sir, I already made a pull request before you assigned it to me. I am new to open source contributions. What should i do now? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGHXROVJKBCKMS4ORIPEEGDTSYKCTANCNFSM44Z7UCXQ> .

[Divyansh0811]

Thank you for being so kind :)