feat(s3): Refactor S3FileSystemFactory to use constants for AWS region management

Author: TheMeinerLP

src/main/java/dev/themeinerlp/bluemap/s3/storage/S3FileSystemFactory.java

@@ -8,6 +8,10 @@
 import java.util.Objects;
 
 final class S3FileSystemFactory {
+
+    private static final String AWS_REGION_KEY = "aws.region";
+    public static final String DEFAULT_AWS_REGION = "us-east-1";
+
     public record S3Fs(FileSystem fileSystem, URI uri) {}
 
     private static S3FileSystemProvider PROVIDER;
@@ -23,21 +27,19 @@ public static S3Fs build(S3Configuration cfg) {
         final boolean thirdParty = cfg.getEndpointUrl() != null && !cfg.getEndpointUrl().isBlank();
         try {
             final URI uri;
-            if (!thirdParty) {
-                // AWS S3 – the provider uses the default region/credentials chain
-                PROVIDER = new S3FileSystemProvider();
-                System.setProperty("aws.region", cfg.getRegion() != null ? cfg.getRegion() : "us-east-1");
-                uri = URI.create("s3://" + cfg.getBucketName());
-            } else {
+            if (thirdParty) {
                 PROVIDER = new S3XFileSystemProvider();
                 var url = URI.create(cfg.getEndpointUrl());
                 System.setProperty("s3.spi.endpoint-protocol", url.toString().startsWith("https") ? "https" : "http");
-                System.setProperty("aws.region", cfg.getRegion() != null ? cfg.getRegion() : "us-east-1");
+                System.setProperty(AWS_REGION_KEY, cfg.getRegion() != null ? cfg.getRegion() : DEFAULT_AWS_REGION);
                 String userInfo = buildUserInfo(cfg);
                 uri = new URI("s3x", userInfo, url.getHost(), url.getPort(), "/" + cfg.getBucketName(), null, null);
+            } else {
+                // AWS S3 – the provider uses the default region/credentials chain
+                PROVIDER = new S3FileSystemProvider();
+                System.setProperty(AWS_REGION_KEY, cfg.getRegion() != null ? cfg.getRegion() : DEFAULT_AWS_REGION);
+                uri = URI.create("s3://" + cfg.getBucketName());
             }
-            System.out.println("Using S3 FileSystem Provider: " + PROVIDER.getClass().getName());
-            System.out.println("Using S3 URI: " + uri);
             FileSystem fs =  PROVIDER.getFileSystem(uri);
             return new S3Fs(fs, uri);
         } catch (Exception e) {