Fix hanging (?) and pre-fetch members

Author: TheMonDon

commands/Economy/add-money-role.js

@@ -78,8 +78,6 @@ class AddMoneyRole extends Command {
       return msg.channel.send({ embeds: [errEmbed] });
     }
 
-    // Ensure the members cache is populated
-    await msg.guild.members.fetch();
     const members = [...role.members.values()];
 
     amount = BigInt(amount);

commands/Economy/clean-leaderboard.js

@@ -28,7 +28,6 @@ class CleanLeaderboard extends Command {
 
     const message = await msg.channel.send({ embeds: [em] });
 
-    await msg.guild.members.fetch();
     for (const i in users) {
       if (!msg.guild.members.cache.get(i)) toRemove.push(i);
     }

commands/Economy/economy-stats.js

@@ -17,7 +17,6 @@ class EconomyStats extends Command {
   }
 
   async run(msg, _args) {
-    await msg.guild.members.fetch();
     const connection = await this.client.db.getConnection();
 
     const [economyRows] = await connection.execute(

commands/Economy/leaderboard.js

@@ -49,7 +49,6 @@ class Leaderboard extends Command {
 
     // Fetch data for the current page
     const offset = (page - 1) * itemsPerPage;
-    await msg.guild.members.fetch();
     const usersData = (await db.get(`servers.${msg.guild.id}.users`)) || {};
 
     const sortedLeaderboard = Object.entries(usersData)

commands/Economy/remove-money-role.js

@@ -68,8 +68,6 @@ class RemoveMoneyRole extends Command {
       [msg.guild.id],
     );
 
-    // Ensure the members cache is populated
-    await msg.guild.members.fetch();
     const members = [...role.members.values()];
 
     amount = BigInt(parseInt(amount));

commands/General/bot-info.js

@@ -17,7 +17,6 @@ class BotInfo extends Command {
   }
 
   async run(msg) {
-    await this.client.guilds.cache.forEach((g) => g.available && g.members.fetch());
     const botUptime = moment
       .duration(this.client.uptime)
       .format('y[ years][,] M[ months][,] d[ days][,] h[ hours][,] m[ minutes][ and] s[ seconds]');

commands/Information/perms.js

@@ -20,7 +20,6 @@ class Permissions extends Command {
 
     // If a user is mentioned, fetch them and set them as the infoMemOrRole
     if (args?.length > 0) {
-      await msg.guild.members.fetch();
       infoMemOrRole = await this.client.util.getMember(msg, args.join(' '));
     }
 

commands/Information/role-info.js

@@ -25,8 +25,6 @@ class RoleInfo extends Command {
     const time = then.from(moment());
     const ca = then.format('dddd, MMMM Do, YYYY, h:mm a');
 
-    await msg.guild.members.fetch();
-
     const hexColor = infoRole.hexColor.toString().toUpperCase();
     const color = hexColor === '#000000' ? 'None' : hexColor;
     const embed = new EmbedBuilder()
@@ -38,7 +36,6 @@ class RoleInfo extends Command {
         { name: 'ID', value: infoRole.id.toString(), inline: true },
         { name: 'Mention', value: `\`${infoRole}\``, inline: true },
         { name: 'Color', value: color, inline: true },
-        { name: 'Members', value: infoRole.members.size.toLocaleString(), inline: true },
         { name: 'Position', value: `${infoRole.position}/${msg.guild.roles.cache.size}`, inline: true },
         { name: 'Mentionable', value: infoRole.mentionable.toString(), inline: true },
         { name: 'Managed', value: infoRole.managed.toString(), inline: true },

commands/Information/server-info.js

@@ -32,7 +32,6 @@ class ServerInfo extends Command {
         'Invalid Server',
       );
     if (!server.available) return this.client.util.errorEmbed(msg, 'That server is currently unavailable');
-    await server.members.fetch();
 
     // Get the server's creation date and format it
     const then = moment(server.createdAt);

events/Bot/clientReady.mjs

@@ -20,6 +20,17 @@ export async function run(client) {
   client.games.clear();
   client.logger.log(`${client.user.tag}, ready to serve ${client.guilds.cache.size} guilds.`, 'ready');
 
+  for (const [, guild] of client.guilds.cache) {
+    try {
+      // This fetches all members and stores them in guild.members.cache
+      await guild.members.fetch();
+    } catch (err) {
+      console.error(`❌ Failed to fetch members for ${guild.name}:`, err);
+    }
+
+    await new Promise((resolve) => setTimeout(resolve, 500));
+  }
+
   if (BotPanelID?.length > 0 && BotPanelSecret?.length > 0) {
     const BotPanelClient = new Client({ id: BotPanelID, secret: BotPanelSecret });