Use internal APIs instead of raw data access

Author: plusmouse

Search/SearchEverywhere.lua

@@ -16,7 +16,7 @@ local function CacheCharacter(character, callback)
     end
   end
 
-  local characterData = CopyTable(SYNDICATOR_DATA.Characters[character])
+  local characterData = CopyTable(Syndicator.API.GetCharacter(character))
 
   local bagsList = {}
   for _, bag in ipairs(characterData.bags) do
@@ -65,7 +65,7 @@ end
 local function CacheGuild(guild, callback)
   local guildList = {}
   local linkToTabIndex = {}
-  for tabIndex, tab in ipairs(CopyTable(SYNDICATOR_DATA.Guilds[guild].bank)) do
+  for tabIndex, tab in ipairs(CopyTable(Syndicator.API.GetGuild(guild).bank)) do
     for _, item in ipairs(tab.slots) do
       if item.itemLink then
         linkToTabIndex[item.itemLink] = tabIndex
@@ -152,11 +152,11 @@ function Syndicator.Search.RequestSearchEverywhereResults(searchTerm, callback)
       Warband = {},
     }
 
-    for c in pairs(SYNDICATOR_DATA.Characters) do
+    for _, c in ipairs(Syndicator.API.GetAllCharacters()) do
       pending.Characters[c] = true
     end
 
-    for g in pairs(SYNDICATOR_DATA.Guilds) do
+    for _, g in ipairs(Syndicator.API.GetAllGuilds()) do
       pending.Guilds[g] = true
     end
 
@@ -261,7 +261,7 @@ function Syndicator.Search.CombineSearchEverywhereResults(results, callback)
       local source = CopyTable(r.source)
       source.itemCount = r.itemCount
       if source.character then
-        local characterData = SYNDICATOR_DATA.Characters[source.character]
+        local characterData = Syndicator.API.GetCharacter(source.character)
         if not characterData.details.hidden and (source.container ~= "equipped" or Syndicator.Config.Get(Syndicator.Config.Options.SHOW_EQUIPPED_ITEMS_IN_TOOLTIPS)) then
           if seenCharacters[key][source.character .. "_" .. source.container] then
             local entry = items[key].sources[seenCharacters[key][source.character .. "_" .. source.container]]
@@ -275,7 +275,7 @@ function Syndicator.Search.CombineSearchEverywhereResults(results, callback)
           items[key].itemCount = items[key].itemCount + r.itemCount
         end
       elseif source.guild then
-        local guildData = SYNDICATOR_DATA.Guilds[source.guild]
+        local guildData = Syndicator.API.GetGuild(source.guild)
         if not guildData.details.hidden then
           if seenGuilds[key][source.guild] then
             local entry = items[key].sources[seenGuilds[key][source.guild]]
@@ -361,7 +361,7 @@ local function PrintSource(indent, source, searchTerm)
     if addonTable.ShowItemLocationCallback then
       character = GetLink(source, searchTerm, source.character)
     end
-    local characterData = SYNDICATOR_DATA.Characters[source.character]
+    local characterData = Syndicator.API.GetCharacter(source.character)
     local className = characterData.details.className
     if className then
       character = "|c" .. (CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS)[className].colorStr .. character .. "|r"

Tracking/CurrencyTooltipData.lua

@@ -12,7 +12,8 @@ function Syndicator.Tracking.GetCurrencyTooltipData(currencyID, sameConnectedRea
   local currentFaction = UnitFactionGroup("player")
 
   local summary = {}
-  for character, info in pairs(SYNDICATOR_DATA.Characters) do
+  for _, character in pairs(Syndicator.API.GetAllCharacters()) do
+    local info = Syndicator.API.GetCharacter(character)
     if not info.details.hidden and (not sameConnectedRealm or matchingRealms[info.details.realmNormalized]) and (not sameFaction or info.details.faction == currentFaction) then
       if info.currencies and info.currencies[currencyID] and info.currencies[currencyID] > 0 then
         table.insert(summary, {

Tracking/ItemSummaries.lua

@@ -323,11 +323,11 @@ function SyndicatorItemSummariesMixin:GetTooltipInfo(key, sameConnectedRealm, sa
     if charactersByRealm then
       for char, summary in pairs(charactersByRealm) do
         local byKey = summary[key]
-        local characterDetails = SYNDICATOR_DATA.Characters[char .. "-" .. r].details
+        local characterDetails = Syndicator.API.GetCharacter(char .. "-" .. r).details
         if byKey ~= nil and characterDetails.show.inventory and (not sameFaction or characterDetails.faction == currentFaction) then
           table.insert(result.characters, {
-            character = char,
-            realmNormalized = r,
+            character = characterDetails.character,
+            realmNormalized = characterDetails.realmNormalized,
             className = characterDetails.className,
             race = characterDetails.race,
             sex = characterDetails.sex,
@@ -348,7 +348,7 @@ function SyndicatorItemSummariesMixin:GetTooltipInfo(key, sameConnectedRealm, sa
         local guildDetails = SYNDICATOR_DATA.Guilds[guild .. "-" .. r].details
         if byKey ~= nil and guildDetails.show.inventory and (not sameFaction or guildDetails.faction == currentFaction) then
           table.insert(result.guilds, {
-            guild = guild,
+            guild = guildDetails.guild,
             realmNormalized = r,
             bank = byKey.bank or 0
           })
@@ -359,7 +359,7 @@ function SyndicatorItemSummariesMixin:GetTooltipInfo(key, sameConnectedRealm, sa
 
   local currentGuild = Syndicator.API.GetCurrentGuild()
   if currentGuild then
-    local currentGuildDetails = SYNDICATOR_DATA.Guilds[currentGuild].details
+    local currentGuildDetails = Syndicator.API.GetGuild(currentGuild).details
     if not FindInTableIf(result.guilds, function(a) return a.guild == currentGuildDetails.guild and a.realmNormalized == currentGuildDetails.realm end) and self.SV.Guilds.ByRealm[currentGuildDetails.realm] then
       local summary = self.SV.Guilds.ByRealm[currentGuildDetails.realm][currentGuildDetails.guild]
       if summary then