Skip to content

Commit a8a2078

Browse files
committed
Improved resource management in CustomArgumentTypes
Wrapped `PlayerCache.getOfflinePlayers()` in a try-with-resources block to ensure proper resource handling.
1 parent e8ec6cd commit a8a2078

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

paper/src/main/java/core/paper/command/CustomArgumentTypes.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,13 @@ public static ArgumentType<OfflinePlayer> cachedOfflinePlayer() {
3636
if (player != null) return player;
3737
throw NO_PLAYER_FOUND.createWithContext(reader);
3838
}, (context, builder) -> CompletableFuture.supplyAsync(() -> {
39-
PlayerCache.getOfflinePlayers()
39+
try (var players = PlayerCache.getOfflinePlayers()
4040
.map(OfflinePlayer::getName)
4141
.filter(Objects::nonNull)
4242
.filter(s -> s.toLowerCase().contains(builder.getRemainingLowerCase()))
43-
.limit(100)
44-
.forEach(builder::suggest);
43+
.limit(100)) {
44+
players.forEach(builder::suggest);
45+
}
4546
return builder.build();
4647
}));
4748
}

0 commit comments

Comments
 (0)