-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Open
Labels
Status: Needs ReviewThis issue/PR needs an initial or additional reviewThis issue/PR needs an initial or additional review
Description
Checks
- I have thoroughly read and understand The Odin Project Contributing Guide
- The title of this issue follows the
Feature Request: brief description of feature requestformat, e.g.Feature Request: Add a dark mode to the website - Would you like to work on this issue?
Description of the Feature Request
In dark mode, the assignment panel (.lesson-content__panel) and inline code blocks have distinctly different background colours to the page. In light mode, the page background is --color-gray-50 while the assignment panel and non-assignment inline code blocks are --color-gray-100, which on my screen are indiscernible from the page background. This feels unintentional. The assignment panel inline code blocks in light mode are --color-gray-200 which are distinct enough.
Acceptance criteria
In light mode only:
- Background colour for assignment panel changed to
--color-gray-200. - Background colour for non-assignment panel inline code blocks changed to
--color-gray-200. - Background colour for assignment panel inline code blocks changed to
--color-gray-300. --tw-prose-codevalue changed tovar(--color-pink-800). Without this, the original--color-pink-700will fail AA contrast against--color-gray-300within assignment panel inline code blocks (4.01). Bumping to pink800 will pass AA with a constrast of 5.36.
Additional Comments
Example of the above changes applied:

Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Status: Needs ReviewThis issue/PR needs an initial or additional reviewThis issue/PR needs an initial or additional review
Type
Projects
Status
π Backlog / Ideas