Skip to content

Commit fe7e03a

Browse files
committed
Attempt to correct BrowserStack configuration (again).
1 parent f9ca849 commit fe7e03a

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

run-ci.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ APK_FILE=$(realpath app.apk)
4141
#
4242

4343
info "Uploading APK to BrowserStack"
44-
BROWSERSTACK_USERNAME=$(yq -r .userName < browserstack.yml)
45-
BROWSERSTACK_ACCESS_KEY=$(yq -r .accessKey < browserstack.yml)
44+
export PALACE_BROWSERSTACK_USERNAME=$(yq -r .userName < browserstack.yml)
45+
export PALACE_BROWSERSTACK_ACCESS_KEY=$(yq -r .accessKey < browserstack.yml)
4646

4747
curl \
48-
-u "$BROWSERSTACK_USERNAME:$BROWSERSTACK_ACCESS_KEY" \
48+
-u "$PALACE_BROWSERSTACK_USERNAME:$PALACE_BROWSERSTACK_ACCESS_KEY" \
4949
-o app.json \
5050
-X POST "https://api-cloud.browserstack.com/app-automate/upload" \
5151
-F "file=@${APK_FILE}"

src/main/java/org/thepalaceproject/ait/AppiumTestContext.java

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import java.net.URL;
1414
import java.util.HashMap;
1515
import java.util.Map;
16+
import java.util.Objects;
1617

1718
public final class AppiumTestContext implements AutoCloseable
1819
{
@@ -56,22 +57,19 @@ private static AppiumTestContext createForBrowserstack(
5657
try {
5758
LOG.debug("Opening Android driver...");
5859

60+
final var username =
61+
System.getenv("PALACE_BROWSERSTACK_USERNAME");
62+
final var accessKey =
63+
System.getenv("PALACE_BROWSERSTACK_ACCESS_KEY");
64+
65+
Objects.requireNonNull(username, "PALACE_BROWSERSTACK_USERNAME");
66+
Objects.requireNonNull(accessKey, "PALACE_BROWSERSTACK_ACCESS_KEY");
67+
5968
final var caps = new DesiredCapabilities();
60-
caps.setCapability("platformName", "Android");
69+
caps.setCapability("browserstack.user", username);
70+
caps.setCapability("browserstack.key", accessKey);
6171
caps.setCapability("app", appId);
62-
caps.setCapability("automationName", "UIAutomator2");
63-
64-
final var bstackOpts = new HashMap<>();
65-
bstackOpts.put("deviceName", "Google Pixel 7");
66-
bstackOpts.put("osVersion", "13.0");
67-
bstackOpts.put("projectName", "PalaceIntegrationTests");
68-
bstackOpts.put("buildName", "Build XYZ");
69-
bstackOpts.put("sessionName", "My test run");
70-
bstackOpts.put("appiumVersion", "2.19.0");
71-
bstackOpts.put("debug", true);
72-
bstackOpts.put("video", true);
73-
74-
caps.setCapability("bstack:options", bstackOpts);
72+
7573
driver = new AndroidDriver(new URL("https://hub.browserstack.com/wd/hub"), caps);
7674
LOG.debug("Opened Android driver.");
7775
resources.add(driver::quit);

0 commit comments

Comments
 (0)