Fix memory leak by releasing JNI global refs in legacy_callbacks (#12)

fatalcoder524 · web-flow · commit 43acc1f4dee3 · 2025-09-26T08:32:16.000+05:30
This commit as been taken from LSPosed-Irena.
diff --git a/core/src/main/jni/src/jni/hook_bridge.cpp b/core/src/main/jni/src/jni/hook_bridge.cpp
@@ -154,6 +154,7 @@ LSP_DEF_NATIVE_METHOD(jboolean, HookBridge, unhookMethod, jboolean useModernApi,
     } else {
         for (auto i = hook_item->legacy_callbacks.begin(); i != hook_item->legacy_callbacks.end(); ++i) {
             if (env->IsSameObject(i->second, callback)) {
+                env->DeleteGlobalRef(i->second);
                 hook_item->legacy_callbacks.erase(i);
                 return JNI_TRUE;
             }

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,7 @@ LSP_DEF_NATIVE_METHOD(jboolean, HookBridge, unhookMethod, jboolean useModernApi,`
`154`	`154`	`} else {`
`155`	`155`	`for (auto i = hook_item->legacy_callbacks.begin(); i != hook_item->legacy_callbacks.end(); ++i) {`
`156`	`156`	`if (env->IsSameObject(i->second, callback)) {`
	`157`	`+ env->DeleteGlobalRef(i->second);`
`157`	`158`	`hook_item->legacy_callbacks.erase(i);`
`158`	`159`	`return JNI_TRUE;`
`159`	`160`	`}`