fix: stat log spam (#18)

This commit fixes the issue that due to early execution of dex2oatd, it would lead to us try to access folders that only exist post-decryption, which takes a while, and before that caused a log spam.

Author: frknkrc44

daemon/src/main/jni/denylist.cpp

@@ -397,6 +397,29 @@ bool apatch_uid_should_umount(const char *const process) {
     return false;
 }
 
+int get_stat(const char* app_name, struct stat* st) {
+    // ignore sandbox package
+    if (strcmp("com.android.sdksandbox", app_name) == 0 ||
+        strcmp("com.google.android.sdksandbox", app_name) == 0) {
+        return -1;
+    }
+
+    char app_data_dir[PATH_MAX];
+    snprintf(app_data_dir, sizeof(app_data_dir), "/data/data/%s", app_name);
+
+    if (stat(app_data_dir, st) == -1) {
+        snprintf(app_data_dir, sizeof(app_data_dir), "/data/user_de/0/%s", app_name);
+
+        if (stat(app_data_dir, st) == -1) {
+            PLOGE("Failed to stat /data/data/%s and /data/user_de/0/%s", app_name, app_name);
+
+            return -1;
+        }
+    }
+
+    return 0;
+}
+
 extern "C" JNIEXPORT jboolean JNICALL
 Java_org_lsposed_lspd_service_DenylistManager_isInDenylist(JNIEnv *env, jclass, jstring appName) {
     const char *app_name = env->GetStringUTFChars(appName, nullptr);
@@ -406,23 +429,16 @@ Java_org_lsposed_lspd_service_DenylistManager_isInDenylist(JNIEnv *env, jclass,
         return JNI_FALSE;
     }
 
-    char app_data_dir[PATH_MAX];
-    snprintf(app_data_dir, sizeof(app_data_dir), "/data/data/%s", app_name);
-
-    struct stat st;
-    if (stat(app_data_dir, &st) == -1) {
-        PLOGE("Failed to stat %s", app_data_dir);
-
-        goto app_not_in_denylist;
-    }
-
     if (root_impl == -1 && !ksu_get_existence() && !magisk_get_existence() && !apatch_get_existence()) {
         LOGE("No supported root implementation found, skipping denylist check");
 
         goto app_not_in_denylist;
     }
 
     if (root_impl == 1) {
+        struct stat st;
+        if (get_stat(app_name, &st) == -1) goto app_not_in_denylist;
+
         if (ksu_is_in_denylist(st.st_uid)) {
             LOGI("App %s is in KernelSU denylist", app_name);
 
@@ -486,23 +502,16 @@ Java_org_lsposed_lspd_service_DenylistManager_isInDenylistFromClasspathDir(JNIEn
     }
     env->ReleaseStringUTFChars(classpathDirArg, classpath_dir_arg);
 
-    char app_data_dir[1024] = {0};
-    snprintf(app_data_dir, sizeof(app_data_dir), "/data/data/%s", app_name);
-
-    struct stat st;
-    if (stat(app_data_dir, &st) == -1) {
-        PLOGE("Failed to stat %s", app_data_dir);
-
-        goto app_not_in_denylist;
-    }
-
     if (root_impl == -1 && !ksu_get_existence() && !magisk_get_existence() && !apatch_get_existence()) {
         LOGE("No supported root implementation found, skipping denylist check");
 
         goto app_not_in_denylist;
     }
 
     if (root_impl == 1) {
+        struct stat st;
+        if (get_stat(app_name, &st) == -1) goto app_not_in_denylist;
+
         if (ksu_is_in_denylist(st.st_uid)) {
             LOGI("App %s is in KernelSU denylist", app_name);