Skip to content

Commit 48c59fa

Browse files
committed
8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT
Reviewed-by: djelinski, jpai, vyazici
1 parent 9d6a61f commit 48c59fa

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

test/jdk/java/net/httpclient/BufferSizePropertyClampTest.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import java.util.ArrayList;
3030
import java.util.Collections;
3131
import java.util.List;
32+
import java.util.Locale;
3233
import java.util.logging.Handler;
3334
import java.util.logging.LogRecord;
3435
import java.util.logging.Logger;
@@ -68,13 +69,20 @@ class BufferSizePropertyClampTest {
6869
private static final List<String> CLIENT_LOGGER_MESSAGES =
6970
Collections.synchronizedList(new ArrayList<>());
7071

72+
private static final String EXPECTED_MSG =
73+
"ERROR: Property value for jdk.httpclient.bufsize={0} not in [1..16,384]: using default=16,384";
74+
75+
private static String format(String pattern, Object... args) {
76+
return new MessageFormat(pattern, Locale.ROOT).format(args);
77+
}
78+
7179
@BeforeAll
7280
static void registerLoggerHandler() {
7381
CLIENT_LOGGER.addHandler(new Handler() {
7482

7583
@Override
7684
public void publish(LogRecord record) {
77-
var message = MessageFormat.format(record.getMessage(), record.getParameters());
85+
var message = format(record.getMessage(), record.getParameters());
7886
CLIENT_LOGGER_MESSAGES.add(message);
7987
}
8088

@@ -97,10 +105,8 @@ void test() {
97105
assertEquals(
98106
1, CLIENT_LOGGER_MESSAGES.size(),
99107
"Unexpected number of logger messages: " + CLIENT_LOGGER_MESSAGES);
100-
var expectedMessage = "ERROR: Property value for jdk.httpclient.bufsize=" +
101-
System.getProperty("jdk.httpclient.bufsize") +
102-
" not in [1..16384]: using default=16384";
103-
assertEquals(expectedMessage, CLIENT_LOGGER_MESSAGES.getFirst().replaceAll(",", ""));
108+
var expectedMessage = format(EXPECTED_MSG, Integer.getInteger("jdk.httpclient.bufsize"));
109+
assertEquals(expectedMessage, CLIENT_LOGGER_MESSAGES.getFirst());
104110
}
105111

106112
}

0 commit comments

Comments
 (0)