Skip to content

Commit fd71f1d

Browse files
committed
Don't trigger hide animation on load + force reflow to avoid chrome bug. Thanks to Sebastian Pettersson
1 parent 0899029 commit fd71f1d

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ng-slide-down",
3-
"version": "0.2.0",
3+
"version": "0.3.0",
44
"authors": [
55
"TheRusskiy <dimanrussian@gmail.com>"
66
],

demo/ng-slide-down.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,10 @@
8686
if (value) {
8787
return $timeout(show);
8888
} else {
89-
element.css({ height: getHeight() });
89+
if (value != null) {
90+
element.css({ height: getHeight() });
91+
element[0].clientHeight;
92+
}
9093
return $timeout(hide);
9194
}
9295
});

dist/ng-slide-down.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,10 @@
8686
if (value) {
8787
return $timeout(show);
8888
} else {
89-
element.css({ height: getHeight() });
89+
if (value != null) {
90+
element.css({ height: getHeight() });
91+
element[0].clientHeight;
92+
}
9093
return $timeout(hide);
9194
}
9295
});

dist/ng-slide-down.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ng-slide-down.coffee

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,11 @@ angular.module("ng-slide-down", []).directive "ngSlideDown", ($timeout )->
6363
if value
6464
$timeout show
6565
else
66-
element.css {
67-
height: getHeight()
68-
}
66+
if value?
67+
element.css {
68+
height: getHeight()
69+
}
70+
element[0].clientHeight # Force reflow so the animation triggers reliably
6971
$timeout hide
7072

7173
return {

0 commit comments

Comments
 (0)