Widened input type of Window.getComputedStyle, allowing subclasses of Element (such as HtmlElement)

Author: TheSpyder

CHANGELOG.md

@@ -16,6 +16,10 @@
 
 - Corrected return type of `getPropertyValue` for CSS style attributes (it's nullable and now returns an option).
 
+#### :bug: Bug Fix
+
+- Widened input type of `Window.getComputedStyle`, allowing subclasses of Element (such as HtmlElement).
+
 # 0.9.1
 
 #### :bug: Bug Fix

lib/js/tests/Webapi/Dom/Webapi__Dom__Window__test.js

@@ -34,6 +34,10 @@ window.focus();
 
 window.getComputedStyle(el);
 
+window.getComputedStyle(el);
+
+window.getComputedStyle(el, "hover");
+
 window.getComputedStyle(el, "hover");
 
 window.getSelection();
@@ -85,7 +89,10 @@ window.onload = (function (param) {
 
   });
 
+var htmlEl = el;
+
 exports.el = el;
+exports.htmlEl = htmlEl;
 exports.$$event = $$event;
 exports.handleClick = handleClick;
 exports.idleId = idleId;

src/Webapi/Dom/Webapi__Dom__Window.res

@@ -78,11 +78,13 @@ module Impl = (
   @send external close: t_window => unit = "close"
   @send external confirm: (t_window, string) => bool = "confirm"
   @send external focus: t_window => unit = "focus"
-  @send external getComputedStyle: (t_window, Dom.element) => Dom.cssStyleDeclaration = "getComputedStyle"
+  @send
+  external getComputedStyle: (t_window, Dom.element_like<'a>) => Dom.cssStyleDeclaration =
+    "getComputedStyle"
   @send
   external getComputedStyleWithPseudoElement: (
     t_window,
-    Dom.element,
+    Dom.element_like<'a>,
     string,
   ) => Dom.cssStyleDeclaration = "getComputedStyle"
   @send @return(nullable) external getSelection: t_window => option<Dom.selection> = "getSelection"

tests/Webapi/Dom/Webapi__Dom__Window__test.res

@@ -1,6 +1,7 @@
 open Webapi.Dom
 
 let el = document->Document.createElement("strong")
+let htmlEl = el->Element.unsafeAsHtmlElement
 let event = document->Document.createEvent("my-event")
 let handleClick = _ => print_endline("asd")
 
@@ -53,7 +54,9 @@ Window.close(window)
 let _ = window->Window.confirm("is ok?")
 Window.focus(window)
 let _ = window->Window.getComputedStyle(el)
+let _ = window->Window.getComputedStyle(htmlEl)
 let _ = window->Window.getComputedStyleWithPseudoElement(el, "hover")
+let _ = window->Window.getComputedStyleWithPseudoElement(htmlEl, "hover")
 let _ = Window.getSelection(window)
 let _ = window->Window.matchMedia("max-height: 400")
 let _ = window->Window.moveBy(10, -10)