Skip to content

Commit 7db05e1

Browse files
committed
Changelog and rename method for #110
1 parent 91af60c commit 7db05e1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,12 @@
4141
* `Node.insertAtEnd` binding (which does `parent.insertBefore(child, null)`) (#89)
4242
* CustomEvent Functor to make custom events with strongly typed `detail` fields (#93)
4343
* `Webapi.Url.createObjectURLFromBlob` binding that takes a `Webapi.Blob.t` (#106)
44+
* `returnValue` setter for `BeforeUnloadEvent` (#110)
4445

4546
### Fixed
4647
* `ofElement` was incorrectly returning `Dom.htmlElement` type instead of the enclosing element type (#60)
4748

4849
### Miscellaneous
4950
* Converted project to rescript syntax (#18)
5051
* Added explicit values to all externals instead of using `= ""` (#40)
51-
* Deprecated `Node.isSameNode` (MDN recommends using `===` instead) (#89)
52+
* Deprecated `Node.isSameNode` (MDN recommends using `===` instead) (#89)

src/Webapi/Dom/Webapi__Dom__BeforeUnloadEvent.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ include Webapi__Dom__Event.Impl({
88
@new external makeWithOptions: (string, {..}) => t = "BeforeUnloadEvent"
99

1010
@get external returnValue: t => string = "returnValue"
11-
@set external returnValue: (t, string) => unit = "returnValue"
11+
@set external setReturnValue: (t, string) => unit = "returnValue"

0 commit comments

Comments
 (0)