Skip to content

Commit bc8c901

Browse files
authored
Merge pull request #122 from mvaled/fix-CustomEvent-makeWithOptions
Fix the CustomEvent's makeWithOption signature.
2 parents f64e3eb + 23f8a77 commit bc8c901

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
* `ofElement` was incorrectly returning `Dom.htmlElement` type instead of the enclosing element type (#60)
5151
* `Dom.CssStyleDeclaration.setPropertyValue` was emitting the wrong function name (#114)
5252
* `Url.toJSON()` was emitting the wrong function name (#121)
53+
* The `options` signature in `Webapi.Dom.CustomEvent`'s `makeWithOption` (#122)
5354

5455
### Miscellaneous
5556
* Converted project to rescript syntax (#18)

src/Webapi/Dom/Webapi__Dom__CustomEvent.res

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ module Make = (
1919
include Webapi__Dom__Event.Impl({
2020
type t = t
2121
})
22+
type options = {detail: Detail.t}
2223

2324
@new external make: string => t = "CustomEvent"
24-
@new external makeWithOptions: (string, Detail.t) => t = "CustomEvent"
25+
@new external makeWithOptions: (string, options) => t = "CustomEvent"
2526
@get external detail: t => Detail.t = "detail"
2627
}

0 commit comments

Comments
 (0)