[BUG]: Video rect not updating

[Jadeon-FPM]

Version

6.11.0

What platforms are you having the problem on?

Android

System Version

Android 15 and 14

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

Our app does does its own handling of PiP on Android and does not use the new built-in react-native-video functionality (yet).

When switching to PiP, then returning, the video is displayed in a portion of the video view that's the same size as the PiP window. It can be forced to update in some circumstances, but I need to investigate that further.

As a sanity check I set the <Video> element's style to have a green background, and the view itself is the correct size, but the video is only drawn to a smaller portion of that view.

I tried a bunch of versions, and found that the issue was introduced in v6.9.0. It is fine in 6.8.2. I took a cursory glance through the changes and didn't see anything obvious.

Reproduction Link

No response

Reproduction

Step to reproduce this bug are:

1. Play a video in fake-fullscreen (with 100% size style)
2. Go into PiP at an app level
3. Return

[github-actions]

Thank you for your bug report. We will review it and get back to you if we need more information.

[Jadeon-FPM]

This appears to also be happening with enterPictureInPictureOnLeave={true}

[rahulnainwalttn]

Getting the same issue in version 6.11.0.

[rahulnainwalttn]

This fixed my issue -

protected void setIsInPictureInPicture(boolean isInPictureInPicture) {
        eventEmitter.onPictureInPictureStatusChanged.invoke(isInPictureInPicture);

        if (fullScreenPlayerView != null && fullScreenPlayerView.isShowing()) {
            if (isInPictureInPicture) fullScreenPlayerView.hideWithoutPlayer();
            return;
        }

        Activity currentActivity = themedReactContext.getCurrentActivity();
        if (currentActivity == null) return;

        View decorView = currentActivity.getWindow().getDecorView();
        ViewGroup rootView = decorView.findViewById(android.R.id.content);

        if (rootView == null) return;

        LayoutParams layoutParams = new LayoutParams(
                LayoutParams.MATCH_PARENT,
                LayoutParams.MATCH_PARENT);

        if (isInPictureInPicture) {
            ViewGroup parent = (ViewGroup) exoPlayerView.getParent();
            if (parent != null && parent != rootView) {
                parent.removeView(exoPlayerView);
            }
            if (exoPlayerView.getParent() == null) {
                rootViewChildrenOriginalVisibility.clear(); // Clear before storing new values

                // Store visibility of all children EXCEPT the exoPlayerView
                for (int i = 0; i < rootView.getChildCount(); i++) {
                    View child = rootView.getChildAt(i);
                    if (child != exoPlayerView) {
                        rootViewChildrenOriginalVisibility.add(child.getVisibility());
                        child.setVisibility(View.GONE);
                    }
                }
                rootView.addView(exoPlayerView, layoutParams);
            }
        } else {
            if (exoPlayerView.getParent() == rootView) {
                rootView.removeView(exoPlayerView);
            }

            // Copy the list before restoring to prevent ConcurrentModificationException
            List<Integer> visibilityCopy = new ArrayList<>(rootViewChildrenOriginalVisibility);
            rootViewChildrenOriginalVisibility.clear();

            // Restore visibility safely
            int restoreCount = Math.min(visibilityCopy.size(), rootView.getChildCount());
            for (int i = 0; i < restoreCount; i++) {
                if (i >= rootView.getChildCount()) break; // Prevent IndexOutOfBoundsException
                rootView.getChildAt(i).setVisibility(visibilityCopy.get(i));
            }

            rootViewChildrenOriginalVisibility.clear(); // Clear after restoring to prevent stale data
            if (exoPlayerView.getParent() == null) { // Double-check before adding
                addView(exoPlayerView, 0, layoutParams);
                Choreographer.getInstance().postFrameCallback(new Choreographer.FrameCallback() {
                    @Override
                    public void doFrame(long frameTimeNanos) {
                        for (int i = 0; i < getChildCount(); i++) {
                            View child = getChildAt(i);
                            child.measure(MeasureSpec.makeMeasureSpec(getMeasuredWidth(), MeasureSpec.EXACTLY),
                                    MeasureSpec.makeMeasureSpec(getMeasuredHeight(), MeasureSpec.EXACTLY));
                            child.layout(0, 0, child.getMeasuredWidth(), child.getMeasuredHeight());
                        }
                        getViewTreeObserver().dispatchOnGlobalLayout();
                        Choreographer.getInstance().postFrameCallback(this);
                    }
                });
            }
        }
    }

[freeboub]

pong @YangJonghun !

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

[Jadeon-FPM]

Not stale