Merge pull request #46 from exaring/use-module-filter-to-drop-zap-frames

TheZeroSlave · web-flow · commit 750a11b209ff · 2024-03-30T11:19:21.000+03:00
fix: use module matching to filter out zap
diff --git a/frame_matcher.go b/frame_matcher.go
@@ -20,7 +20,7 @@ type FrameMatcher interface {
 var (
 	defaultFrameMatchers = FrameMatchers{
 		SkipModulePrefixFrameMatcher("github.com/TheZeroSlave/zapsentry"),
-		SkipFunctionPrefixFrameMatcher("go.uber.org/zap"),
+		SkipModulePrefixFrameMatcher("go.uber.org/zap"),
 	}
 )
 
diff --git a/frame_matcher_test.go b/frame_matcher_test.go
@@ -51,7 +51,7 @@ func Test_core_filterFrames(t *testing.T) {
 			args: args{
 				[]sentry.Frame{
 					{
-						Function: "go.uber.org/zap/String",
+						Module: "go.uber.org/zap",
 					},
 				},
 			},

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ type FrameMatcher interface {`
`20`	`20`	`var (`
`21`	`21`	`defaultFrameMatchers = FrameMatchers{`
`22`	`22`	`SkipModulePrefixFrameMatcher("github.com/TheZeroSlave/zapsentry"),`
`23`		`- SkipFunctionPrefixFrameMatcher("go.uber.org/zap"),`
	`23`	`+ SkipModulePrefixFrameMatcher("go.uber.org/zap"),`
`24`	`24`	`}`
`25`	`25`	`)`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func Test_core_filterFrames(t *testing.T) {`
`51`	`51`	`args: args{`
`52`	`52`	`[]sentry.Frame{`
`53`	`53`	`{`
`54`		`- Function: "go.uber.org/zap/String",`
	`54`	`+ Module: "go.uber.org/zap",`
`55`	`55`	`},`
`56`	`56`	`},`
`57`	`57`	`},`