Skip to content

Commit 981ff8e

Browse files
committed
Better error message for old NCCL.
1 parent c1d3e80 commit 981ff8e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/loaders/libnccl.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ int load_libnccl(error *e) {
4040

4141
#include "libnccl.fn"
4242

43+
if (ga_func_ptr(lib, "ncclGroupStart", e) == NULL)
44+
return error_set(e, GA_LOAD_ERROR, "Found NCCL 1.0 but NCCL 2.0 required");
45+
4346
loaded = 1;
4447
return GA_NO_ERROR;
4548
}

src/loaders/libnccl.fn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,3 @@ DEF_PROC(ncclResult_t, ncclAllReduce, (const void* sendbuff, void* recvbuff, siz
99
DEF_PROC(ncclResult_t, ncclReduceScatter, (const void* sendbuff, void* recvbuff, size_t recvcount, ncclDataType_t datatype, ncclRedOp_t op, ncclComm_t comm, cudaStream_t stream));
1010
DEF_PROC(ncclResult_t, ncclBcast, (void* buff, size_t count, ncclDataType_t datatype, int root, ncclComm_t comm, cudaStream_t stream ));
1111
DEF_PROC(ncclResult_t, ncclAllGather, (const void* sendbuff, void* recvbuff, size_t sendcount, ncclDataType_t datatype, ncclComm_t comm, cudaStream_t stream));
12-
// We don't need this but we use it as a sentinel to prevent nccl 1.0 from loading.
13-
DEF_PROC(ncclResult_t, ncclGroupStart, ());

0 commit comments

Comments
 (0)