Use sNprintf to build libnames and check errors.

Author: notoraptor

src/gpuarray_buffer_cuda.c

@@ -150,7 +150,7 @@ static int setup_lib(void) {
     if (res != GA_NO_ERROR) {
       /* Else, let's try to find a nvrtc corresponding to supported CUDA versions. */
       int versions[][2] = {{8, 0}, {7, 5}, {7, 0}};
-      int versions_length = sizeof(versions) / (2 * sizeof(int));
+      int versions_length = sizeof(versions) / sizeof(versions[0]);
       int i = 0;
       do {
         major = versions[i][0];

src/loaders/libcublas.c

@@ -1,8 +1,5 @@
-#include <stdlib.h>
-#ifdef DEBUG
-/* For fprintf and stderr. */
-#include <stdio.h>
-#endif
+/* To be able to use snprintf with any compiler including MSVC2008. */
+#include <private_config.h>
 
 #include "libcublas.h"
 #include "dyn_load.h"
@@ -45,22 +42,27 @@ int load_libcublas(int major, int minor, error *e) {
 
 #if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
   {
-    const char* libname_pattern = "cublas64_%d%d.dll";
     char libname[64];
-
+    int n;
     #ifdef DEBUG
     fprintf(stderr, "Loading cuBLAS %d.%d.\n", major, minor);
     #endif
-    sprintf(libname, libname_pattern, major, minor);
-
+    n = snprintf(libname, 64, "cublas64_%d%d.dll", major, minor);
+    if (n < 0 || n >= 64)
+      return error_set(e, GA_SYS_ERROR, "cublas library name too long.");
     lib = ga_load_library(libname, e);
   }
 #else /* Unix */
 #ifdef __APPLE__
   {
-    const char* libname_pattern = "/Developer/NVIDIA/CUDA-%d.%d/lib/libcublas.dylib";
     char libname[128];
-    sprintf(libname, libname_pattern, major, minor);
+    int n;
+    #ifdef DEBUG
+    fprintf(stderr, "Loading cuBLAS %d.%d.\n", major, minor);
+    #endif
+    n = snprintf(libname, 128, "/Developer/NVIDIA/CUDA-%d.%d/lib/libcublas.dylib", major, minor);
+    if (n < 0 || n >= 128)
+      return error_set(e, GA_SYS_ERROR, "cublas library path too long.");
     lib = ga_load_library(libname, e);
   }
 #else

src/loaders/libnvrtc.c

@@ -1,8 +1,5 @@
-#include <stdlib.h>
-#ifdef DEBUG
-/* For fprintf and stderr. */
-#include <stdio.h>
-#endif
+/* To be able to use snprintf with any compiler including MSVC2008. */
+#include <private_config.h>
 
 #include "libcuda.h"
 #include "libnvrtc.h"
@@ -31,23 +28,29 @@ int load_libnvrtc(int major, int minor, error *e) {
 
 #if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
   {
-    const char* libname_pattern = "nvrtc64_%d%d.dll";
     char libname[64];
-
+    int n;
     #ifdef DEBUG
     fprintf(stderr, "Loading nvrtc %d.%d.\n", major, minor);
     #endif
-    sprintf(libname, libname_pattern, major, minor);
+    n = snprintf(libname, 64, "nvrtc64_%d%d.dll", major, minor);
+    if (n < 0 || n >= 64)
+      return error_set(e, GA_SYS_ERROR, "nvrtc library name too long.");
 
     lib = ga_load_library(libname, e);
   }
 #else /* Unix */
 #ifdef __APPLE__
   {
     /* Try the usual fullpath first */
-    const char* libname_pattern = "/Developer/NVIDIA/CUDA-%d.%d/lib/libnvrtc.dylib";
     char libname[128];
-    sprintf(libname, libname_pattern, major, minor);
+    int n;
+    #ifdef DEBUG
+    fprintf(stderr, "Loading nvrtc %d.%d.\n", major, minor);
+    #endif
+    n = snprintf(libname, 128, "/Developer/NVIDIA/CUDA-%d.%d/lib/libnvrtc.dylib", major, minor);
+    if (n < 0 || n >= 128)
+      return error_set(e, GA_SYS_ERROR, "nvrtc library path too long.");
     lib = ga_load_library(libname, e);
   }
 #else