Skip to content

Commit b7b94aa

Browse files
committed
Fix summation tests:
- Subtract 0.5 from random numbers, so they sum to 0 in expectation. - Increase tolerance from 1e-5 to 1e-4 just for summation.
1 parent e3dd7a7 commit b7b94aa

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/check_reduction.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,7 +1814,7 @@ START_TEST(test_sum_reduction){
18141814
size_t dims[3] = {32,50,79};
18151815
size_t prodDims = dims[0]*dims[1]*dims[2];
18161816
const int reduxList[] = {0,2};
1817-
const float TOL = 1e-5;
1817+
const float TOL = 1e-4;
18181818

18191819
float* pS = calloc(1, sizeof(*pS) * dims[0]*dims[1]*dims[2]);
18201820
float* pD = calloc(1, sizeof(*pD) * dims[1] );
@@ -1828,7 +1828,7 @@ START_TEST(test_sum_reduction){
18281828
*/
18291829

18301830
for(i=0;i<prodDims;i++){
1831-
pS[i] = pcgRand01();
1831+
pS[i] = pcgRand01()-0.5;
18321832
}
18331833

18341834

@@ -1895,7 +1895,7 @@ START_TEST(test_sum_veryhighrank){
18951895
size_t rdxDims[4] = {1171,373,1,2};
18961896
size_t rdxProdDims = rdxDims[0]*rdxDims[1]*rdxDims[2]*rdxDims[3];
18971897
const int reduxList[] = {2,4,7,5};
1898-
const float TOL = 1e-5;
1898+
const float TOL = 1e-4;
18991899

19001900
float* pS = calloc(1, sizeof(*pS) * prodDims);
19011901
float* pD = calloc(1, sizeof(*pD) * rdxProdDims);
@@ -1909,7 +1909,7 @@ START_TEST(test_sum_veryhighrank){
19091909
*/
19101910

19111911
for(i=0;i<prodDims;i++){
1912-
pS[i] = pcgRand01();
1912+
pS[i] = pcgRand01()-0.5;
19131913
}
19141914

19151915

@@ -1986,7 +1986,7 @@ START_TEST(test_sum_alldimsreduced){
19861986
size_t dims[3] = {32,50,79};
19871987
size_t prodDims = dims[0]*dims[1]*dims[2];
19881988
const int reduxList[] = {0,1,2};
1989-
const float TOL = 1e-5;
1989+
const float TOL = 1e-4;
19901990

19911991
float* pS = calloc(1, sizeof(*pS) * dims[0]*dims[1]*dims[2]);
19921992
float* pD = calloc(1, sizeof(*pD) );
@@ -2000,7 +2000,7 @@ START_TEST(test_sum_alldimsreduced){
20002000
*/
20012001

20022002
for(i=0;i<prodDims;i++){
2003-
pS[i] = pcgRand01();
2003+
pS[i] = pcgRand01()-0.5;
20042004
}
20052005

20062006

0 commit comments

Comments
 (0)