Merge pull request finos#1472 from markscott-ms/fix-flows

fix instantiations of CalmNode and CalmRelationships - missing additionalProperties argument

Author: LeighFinegold

shared/src/docify/graphing/c4.spec.ts

@@ -16,7 +16,8 @@ describe('buildParentChildMappings', () => {
             'rel1',
             new CalmComposedOfType('parent1', ['child1', 'child2']),
             new CalmMetadata({}),
-            []
+            [],
+            {}
         );
         const { parentLookup, childrenLookup } = buildParentChildMappings([composedOfRel]);
         expect(parentLookup).toEqual({ child1: 'parent1', child2: 'parent1' });
@@ -28,7 +29,8 @@ describe('buildParentChildMappings', () => {
             'rel2',
             new CalmDeployedInType('env1', ['service1']),
             new CalmMetadata({}),
-            []
+            [],
+            {}
         );
         const { parentLookup, childrenLookup } = buildParentChildMappings([deployedInRel]);
         expect(parentLookup).toEqual({ service1: 'env1' });
@@ -48,20 +50,23 @@ describe('C4Model', () => {
             new CalmComposedOfType('system1', ['service1', 'service2']),
             new CalmMetadata({}),
             [],
+            {},
             'system1 is composed of service1 & service2'
         );
         const interactsRel = new CalmRelationship(
             'rel2',
             new CalmInteractsType('actor1', ['service1']),
             new CalmMetadata({}),
             [],
+            {},
             'actor1 interacts with service1'
         );
         const connectsRel = new CalmRelationship(
             'rel3',
-            new CalmConnectsType({ node: 'service2', interfaces: [] }, { node: 'actor1', interfaces: []  }),
+            new CalmConnectsType({ node: 'service2', interfaces: [] }, { node: 'actor1', interfaces: [] }),
             new CalmMetadata({}),
             [],
+            {},
             'service2 connects to actor1'
         );
 
@@ -110,7 +115,8 @@ describe('C4Model', () => {
             new CalmNodeDetails('', ''),
             [],
             [],
-            new CalmMetadata({})
+            new CalmMetadata({}),
+            {}
         );
     }
 });

shared/src/docify/graphing/control-registry.spec.ts

@@ -6,7 +6,7 @@ import { CalmNode } from '../../model/node';
 import { CalmRelationship, CalmConnectsType } from '../../model/relationship';
 import { CalmNodeInterface } from '../../model/interface';
 import { CalmFlow, CalmFlowTransition } from '../../model/flow';
-import {CalmControlsSchema} from '../../types/control-types';
+import { CalmControlsSchema } from '../../types/control-types';
 
 describe('ControlRegistry', () => {
     let controlRegistry: ControlRegistry;
@@ -73,7 +73,8 @@ describe('ControlRegistry', () => {
                 undefined,
                 undefined,
                 [nodeControl],
-                new CalmMetadata({})
+                new CalmMetadata({}),
+                {}
             )
         ];
 
@@ -86,6 +87,7 @@ describe('ControlRegistry', () => {
                 ),
                 new CalmMetadata({}),
                 [relationshipControl],
+                {},
                 'Test relationship'
             )
         ];

shared/src/docify/graphing/flow-sequence-helper.spec.ts

@@ -15,10 +15,10 @@ describe('FlowSequenceHelper', () => {
 
         // Create test nodes
         const nodes = [
-            new CalmNode('document-system', 'system', 'DocuFlow', 'Main document management system', undefined, undefined, undefined, new CalmMetadata({})),
-            new CalmNode('svc-upload', 'service', 'Upload Service', 'Handles user document uploads', undefined, undefined, undefined, new CalmMetadata({})),
-            new CalmNode('svc-storage', 'service', 'Storage Service', 'Stores and retrieves documents securely', undefined, undefined, undefined, new CalmMetadata({})),
-            new CalmNode('db-docs', 'database', 'Document Database', 'Stores metadata and document references', undefined, undefined, undefined, new CalmMetadata({}))
+            new CalmNode('document-system', 'system', 'DocuFlow', 'Main document management system', undefined, undefined, undefined, new CalmMetadata({}), {}),
+            new CalmNode('svc-upload', 'service', 'Upload Service', 'Handles user document uploads', undefined, undefined, undefined, new CalmMetadata({}), {}),
+            new CalmNode('svc-storage', 'service', 'Storage Service', 'Stores and retrieves documents securely', undefined, undefined, undefined, new CalmMetadata({}), {}),
+            new CalmNode('db-docs', 'database', 'Document Database', 'Stores metadata and document references', undefined, undefined, undefined, new CalmMetadata({}), {})
         ];
 
         // Create test relationships