[IMP] ..aware_sender: add test for server selection

Author: NL66278

mail_company_aware_sender/static/description/index.html

@@ -8,11 +8,10 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -446,9 +445,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>

mail_company_aware_sender/tests/common.py

@@ -1,5 +1,7 @@
 # Copyright 2025 Therp BV <https://therp.nl>.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from email.utils import parseaddr
+
 from odoo.tests.common import SavepointCase
 
 
@@ -17,6 +19,7 @@ def setUpClass(cls):
                 "name": "localhost",
                 "smtp_host": "localhost",
                 "domain_whitelist": "therp.nl",
+                "sequence": 99,
             }
         )
         cls.company_kingdom = cls.Company.create(
@@ -58,3 +61,10 @@ def setUpClass(cls):
                 "company_id": cls.company_imperium.id,
             }
         )
+
+    def _assert_email(self, email_from, expected_email, expected_name=None):
+        """Assert email_from matches expected parts, tolerant to quoting differences."""
+        name, email = parseaddr(email_from or "")
+        self.assertEqual(email, expected_email)
+        if expected_name is not None:
+            self.assertEqual(name, expected_name)

mail_company_aware_sender/tests/test_company_aware_sender.py

@@ -1,18 +1,10 @@
 # Copyright 2025 Therp BV <https://therp.nl>.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from email.utils import parseaddr
 
 from .common import CompanyAwareSenderCase
 
 
 class TestCompanyAwareSender(CompanyAwareSenderCase):
-    def _assert_email(self, email_from, expected_email, expected_name=None):
-        """Assert email_from matches expected parts, tolerant to quoting differences."""
-        name, email = parseaddr(email_from or "")
-        self.assertEqual(email, expected_email)
-        if expected_name is not None:
-            self.assertEqual(name, expected_name)
-
     def test_nothing_changed(self):
         # Check with default user and author (current user).
         mail_thread = (

mail_company_aware_sender/tests/test_mail_server.py

@@ -1,20 +1,12 @@
-# Copyright 2025 Therp BV <https://therp.nl>.
+# Copyright 2025-2026 Therp BV <https://therp.nl>.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from email.utils import parseaddr
 
 from odoo.exceptions import ValidationError
 
 from .common import CompanyAwareSenderCase
 
 
 class TestMailServer(CompanyAwareSenderCase):
-    def _assert_email(self, email_from, expected_email, expected_name=None):
-        """Assert email_from matches expected parts, tolerant to quoting differences."""
-        name, email = parseaddr(email_from or "")
-        self.assertEqual(email, expected_email)
-        if expected_name is not None:
-            self.assertEqual(name, expected_name)
-
     def test_test_email_adresses(self):
         # Whitelist domain, and enable from address.
         self.mail_server.write(
@@ -54,3 +46,32 @@ def test_disable_encapsulation(self):
             self.company_imperium
         )._get_default_from_address()
         self.assertEqual(email_from, None)
+
+    def test_email_server_selection(self):
+        # When one server has domain whitelisted, that server should send message.
+        self.IrMailServer.create(
+            {
+                "name": "default mail server",
+                "smtp_host": "localhost",
+                "domain_whitelist": "therp.nl",
+                "sequence": 5,
+            }
+        )
+        self.mail_server.write(
+            {
+                "smtp_from": "info@imperiumromanum.org",
+                "domain_whitelist": "imperiumromanum.org",
+            }
+        )
+        # Partner charles in imperium should use company aware from.
+        email_from, email_to = (
+            self.mail_server.with_user(self.user_charles)
+            .with_company(self.company_imperium)
+            ._get_test_email_addresses()
+        )
+        self._assert_email(email_from, "charlemagne@imperiumromanum.org")
+        # Call the (misspelled) _get_mail_sever method, defined in the
+        # mail_outbound_static module, to select the right mail server.
+        mail_server_id = self.IrMailServer._get_mail_sever("imperiumromanum.org")
+        # The server with the domain should be used, despite higher sequence.
+        self.assertEqual(mail_server_id, self.mail_server.id)