Skip to content

Commit 6b55c49

Browse files
committed
fix(core): fixing few warnings mostly exhaustive when
1 parent dc8d720 commit 6b55c49

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

core/src/main/java/io/github/thibaultbee/streampack/core/elements/encoders/mediacodec/EncoderInfo.kt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ sealed class EncoderInfo(codecInfo: MediaCodecInfo, mimeType: String) : IEncoder
2828

2929
class VideoEncoderInfo(codecInfo: MediaCodecInfo, mimeType: String) :
3030
EncoderInfo(codecInfo, mimeType) {
31-
private val videoCapabilities = codecCapabilities.videoCapabilities
31+
private val videoCapabilities = requireNotNull(codecCapabilities.videoCapabilities) {
32+
"Video capabilities are null for encoder $name and mime type $mimeType"
33+
}
3234

3335
val supportedWidths = videoCapabilities.supportedWidths
3436
val supportedHeights = videoCapabilities.supportedHeights
@@ -38,7 +40,9 @@ class VideoEncoderInfo(codecInfo: MediaCodecInfo, mimeType: String) :
3840

3941
class AudioEncoderInfo(codecInfo: MediaCodecInfo, mimeType: String) :
4042
EncoderInfo(codecInfo, mimeType) {
41-
private val audioCapabilities = codecCapabilities.audioCapabilities
43+
private val audioCapabilities = requireNotNull(codecCapabilities.audioCapabilities) {
44+
"Audio capabilities are null for encoder $name and mime type $mimeType"
45+
}
4246

4347
val supportedSampleRates = audioCapabilities.supportedSampleRates
4448
val supportedBitrates = audioCapabilities.bitrateRange

core/src/main/java/io/github/thibaultbee/streampack/core/elements/endpoints/composites/muxers/mp4/models/TrackChunks.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ class TrackChunks(
240240
val resolution = when (config) {
241241
is AudioCodecConfig -> Size(0, 0)
242242
is VideoCodecConfig -> format.resolution
243-
else -> throw IllegalArgumentException("Unsupported config")
244243
}
245244
val volume = when (config) {
246245
is AudioCodecConfig -> 1.0f

core/src/main/java/io/github/thibaultbee/streampack/core/elements/endpoints/composites/muxers/mp4/utils/CodecConfigExtensions.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,12 @@ fun CodecConfig.createTypeMediaHeaderBox(): TypeMediaHeaderBox {
2727
return when (this) {
2828
is AudioCodecConfig -> SoundMediaHeaderBox()
2929
is VideoCodecConfig -> VideoMediaHeaderBox()
30-
else -> throw IllegalArgumentException("Unsupported config")
3130
}
3231
}
3332

3433
fun CodecConfig.createHandlerBox(): HandlerBox {
3534
return when (this) {
3635
is AudioCodecConfig -> HandlerBox(HandlerBox.HandlerType.SOUND, "SoundHandler")
3736
is VideoCodecConfig -> HandlerBox(HandlerBox.HandlerType.VIDEO, "VideoHandler")
38-
else -> throw IllegalArgumentException("Unsupported config")
3937
}
4038
}

0 commit comments

Comments
 (0)