[Feat]: Render correct preview size for bitmap and non-camera sources in landscape orientation

[dimadesu]

Version

Almost the latest

Environment that reproduces the issue

Hi @ThibaultBee! Love your project. Thanks for all your hard work.

I've built an app that can use RTMP as custom video/audio source with StreamPack SDK https://github.com/dimadesu/LifeStreamer

I'm here to propose a fix (or a feature maybe 🤷‍♂️ ) to PreviewView.kt.

Use case description

Camera demo has issue when bitmap is in landscape orientation: preview shows landscape bitmap as portrait.

I think this is an issue with all non-camera sources.

Proposed solution

I've found a simple fix.

Works for me really well for both bitmap and RTMP sources.

It's hard to fix in app itself, so I had to copy the whole PreviewView.kt into my app and tweak it.
Looks like something that is ideally fixed in the SDK itself.
I can put together a PR if needed.
Thanks!

Alternative solutions

No response

[ThibaultBee]

Hi,
Thanks for the reporting.

I plan to upgrade the viewfinder package soon. I think I am going to add infoProviderFlow in the IPreviewableSource interface, and pass the rotationDegrees of the ISourceInfoProvider in the surface configuration.

[dimadesu]

Got it. Thanks for your explanation. I sort of understand. You're really good with architecture, so I'm sure it will turn out great.
I guess we can close this issue then.

[ThibaultBee]

Just push feature/upgrade_viewfinder branch so you can get the idea.
It is just a draft and it does not work properly yet.

But as it increases min SDK to 23, I am not going to add it right now. So could you make a PR with your code?
Also could you provide screenshot of before/after the PR please?

(I got idea for your app, feel free to contact me on linkedin)

[dimadesu]

Thanks for sharing the branch. I had a look. My understanding it will use ViewfinderView that can adjust preview if orientation is passed for any source. Smth like that. That's cool.

Okay, no worries, I'll create a PR.

Sent you a LinkedIn request. Curious to find out your ideas.

[dimadesu]

Okay PR is ready #239 please check.
Yeah much easier to understand what it does with images before/after.

[ThibaultBee]

Patch rebase.

Keep it mind it is just a temporary workaround.

[dimadesu]

Awesome! Thanks for merging 🙌 .

[ThibaultBee]

Released in 3.0.1