Road to v0.2.3

Author: statnmap

.gitignore

@@ -33,3 +33,4 @@ docs/*
 inst/doc
 cran-comments.md
 revdep/
+CRAN-RELEASE

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: attachment
 Title: Deal with Dependencies
-Version: 0.2.2
+Version: 0.2.3
 Authors@R:
     c(person(given = "Sébastien",
              family = "Rochette",

NEWS.md

@@ -1,4 +1,4 @@
-# attachment 0.2.2
+# attachment 0.2.3
 
 ## Major changes
 

dev/dev_history.R

@@ -87,6 +87,18 @@ usethis::use_vignette("fill-pkg-description")
 devtools::build_vignettes()
 devtools::check()
 
+# Check for remotes
+packageDescription("glue")[["Repository"]]
+remotes::install_github("tidyverse/glue")
+# restart session
+rstudioapi::restartSession()
+devtools::test()
+# install back from CRAN
+install.packages("glue")
+# restart session
+rstudioapi::restartSession()
+devtools::test()
+
 # Checks for CRAN release ----
 # Check package as CRAN
 rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"))

tests/testthat/test-to-description.R

@@ -174,11 +174,37 @@ file.copy(system.file("dummypackage",package = "attachment"), tmpdir, recursive
 dummypackage <- file.path(tmpdir, "dummypackage")
 
 test_that("set_remotes_to_desc return nothing if local installs", {
-  expect_message(
-    att_amend_desc(dummypackage) %>%
-      set_remotes_to_desc(),
-    "no remote packages installed"
-  )
+
+    pkgs <- att_amend_desc(dummypackage) %>%
+      att_from_description()
+    remotes <- find_remotes(pkgs)
+
+    desc_file <- file.path(dummypackage, "DESCRIPTION")
+
+    if (is.null(remotes)) {
+      # Do not test if some are compiled locally
+      expect_message(
+        set_remotes_to_desc(desc_file),
+        "no remote packages installed"
+      )
+    } else {
+      pkgnames <- glue::glue_collapse(names(remotes), sep = ", ", last = " & ")
+      nona <- unlist(lapply(remotes, is.na))
+      expect_message(
+        set_remotes_to_desc(desc_file),
+        paste("Remotes for", pkgnames[nona])
+      )
+    }
+
+    # Add attachment in DESCRIPTION as should be local installed
+    desc_lines <- readLines(desc_file)
+    desc_lines[desc_lines == "Suggests: "] <- "Suggests: \n    attachment,"
+    writeLines(desc_lines, con = desc_file)
+
+    expect_message(
+      set_remotes_to_desc(desc_file),
+      "Package attachment was probably installed from source locally"
+    )
 })
 
 # Test missing DESCRIPTION works ----