Silence one of the duplicated "Loading" messages from run_dev()#1200
Closed
howardbaik wants to merge 1 commit intoThinkR-open:masterfrom
Closed
Silence one of the duplicated "Loading" messages from run_dev()#1200howardbaik wants to merge 1 commit intoThinkR-open:masterfrom
run_dev()#1200howardbaik wants to merge 1 commit intoThinkR-open:masterfrom
Conversation
Member
|
Thanks a lot @howardbaik 🙏 I wasn't aware of this param for pkgload::load_all() I've cherry-picked your commit in a new branch that is here (you'll still see the commit) : #1201) I've moved things around a bit — I prefer that the pkgload_load_all function stays with the default param (if ever we need to call it again at some point), and change the param inside document_and_reload. In case you were wondering, the function in bootsrap_* are a copycat of the default functions, with just a check that the package is installed. I've also bump the version number and added an entry in the NEWS. Thanks again. |
Contributor
Author
|
I’m really glad I could contribute—thanks so much for all your work on golem. It’s been an absolute lifesaver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
pkgload_load_all(), I set the default value ofquiettoTRUEto suppress the output frompkgload::load_all().This change addresses #1191.