Skip to content

Commit e9a167b

Browse files
committed
fix imrope check
1 parent 473ee90 commit e9a167b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ggml/src/ggml-cpu/ops.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5599,7 +5599,7 @@ static void ggml_compute_forward_rope_f32(
55995599

56005600
const bool is_neox = mode & GGML_ROPE_TYPE_NEOX;
56015601
const bool is_mrope = mode & GGML_ROPE_TYPE_MROPE; // ggml_rope_multi, multimodal rotary position embedding
5602-
const bool is_imrope = mode & GGML_ROPE_TYPE_IMROPE; // qwen3vl apply interleaved mrope
5602+
const bool is_imrope = mode == GGML_ROPE_TYPE_IMROPE; // qwen3vl apply interleaved mrope
56035603
const bool is_vision = mode == GGML_ROPE_TYPE_VISION;
56045604

56055605
if (is_mrope) {
@@ -5786,7 +5786,7 @@ static void ggml_compute_forward_rope_f16(
57865786

57875787
const bool is_neox = mode & GGML_ROPE_TYPE_NEOX;
57885788
const bool is_mrope = mode & GGML_ROPE_TYPE_MROPE;
5789-
const bool is_imrope = mode & GGML_ROPE_TYPE_IMROPE;
5789+
const bool is_imrope = mode == GGML_ROPE_TYPE_IMROPE;
57905790
const bool is_vision = mode == GGML_ROPE_TYPE_VISION;
57915791

57925792
if (is_mrope) {

ggml/src/ggml-cuda/rope.cu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ void ggml_cuda_op_rope_impl(ggml_backend_cuda_context & ctx, ggml_tensor * dst)
379379

380380
const bool is_neox = mode & GGML_ROPE_TYPE_NEOX;
381381
const bool is_mrope = mode & GGML_ROPE_TYPE_MROPE;
382-
const bool is_imrope = mode & GGML_ROPE_TYPE_IMROPE;
382+
const bool is_imrope = mode == GGML_ROPE_TYPE_IMROPE;
383383
const bool is_vision = mode == GGML_ROPE_TYPE_VISION;
384384

385385
if (is_mrope) {

tools/mtmd/clip.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,7 @@ struct clip_graph {
986986
// residual 2
987987
cur = ggml_add(ctx0, inpL, cur);
988988
cb(cur, "layer_out", il);
989-
989+
990990
if (layer.has_deepstack()) {
991991
ggml_tensor * feat = ggml_reshape_3d(ctx0, cur, n_embd * merge_factor, n_pos / merge_factor, batch_size);
992992
feat = build_norm(feat, layer.deepstack_norm_w, layer.deepstack_norm_b, norm_t, eps, il);

0 commit comments

Comments
 (0)