Skip to content

Commit ec129ac

Browse files
committed
Update replace all in supported browsers
1 parent 5fe7ff2 commit ec129ac

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

bin/compile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,26 @@ if [ -z "$BUILDPACK_BROWSERS_INSTALL_PATH" ]; then
1212
fi
1313

1414
if [ -z "$PLAYWRIGHT_BUILDPACK_BROWSERS" ]; then
15+
# follow format of https://github.com/playwright-community/heroku-playwright-buildpack/blob/master/bin/compile
1516
SUPPORTED_BROWSERS=${PLAYWRIGHT_BUILDPACK_BROWSERS:-chromium,firefox,webkit}
16-
echo "Installing Playwright dependencies (env: PLAYWRIGHT_BUILDPACK_BROWSERS) for $SUPPORTED_BROWSERS."
1717
fi
1818

1919
export PLAYWRIGHT_BROWSERS_PATH=$BUILD_DIR/$BUILDPACK_BROWSERS_INSTALL_PATH
2020
echo "-----> BROWSERS_INSTALL_PATH is $BUILDPACK_BROWSERS_INSTALL_PATH"
2121
echo "-----> Browsers will be installed in $PLAYWRIGHT_BROWSERS_PATH"
22-
echo "-----> Formatted values are ${SUPPORTED_BROWSERS/,/ }"
23-
playwright install ${SUPPORTED_BROWSERS/,/ }
22+
echo "----->Installing Playwright executables (env: PLAYWRIGHT_BUILDPACK_BROWSERS) for ${SUPPORTED_BROWSERS//,/ }."
23+
playwright install ${SUPPORTED_BROWSERS//,/ }
2424
echo "-----> Installation done"
2525

2626
# export the file path as a ENV
2727
CHROMIUM_EXECUTABLE_PATH=${find ~+ -type f -name "chrome"}
2828
FIREFOX_EXECUTABLE_PATH=${find ~+ -type f -name "geckodriver"}
2929
WEBKIT_EXECUTABLE_PATH=${find ~+ -type f -name "webkit"}
3030

31+
echo "----> CHROMIUM_EXECUTABLE_PATH is $CHROMIUM_EXECUTABLE_PATH"
32+
echo "----> FIREFOX_EXECUTABLE_PATH is $FIREFOX_EXECUTABLE_PATH"
33+
echo "----> WEBKIT_EXECUTABLE_PATH is $WEBKIT_EXECUTABLE_PATH"
34+
3135
if [ -v "$CHROMIUM_EXECUTABLE_PATH" ]; then
3236
echo $CHROMIUM_EXECUTABLE_PATH > $ENV_DIR/CHROMIUM_EXECUTABLE_PATH
3337
fi

0 commit comments

Comments
 (0)