RpcNamespaceIssue: append Request, use string

Thomas-Gelf · Thomas-Gelf · commit 47609a4a9da2 · 2025-11-10T15:48:41.000+01:00
diff --git a/library/Eventtracker/Daemon/RpcNamespace/RpcNamespaceIssue.php b/library/Eventtracker/Daemon/RpcNamespace/RpcNamespaceIssue.php
@@ -100,11 +100,12 @@ protected function close(UuidInterface $uuid, $reason, $closedBy = null): bool
      * @param string $ticketReference
      * @return bool
      */
-    protected function acknowledge(UuidInterface $uuid, string $owner, ?string $ticketReference = null): bool
+    public function acknowledgeRequest(string $issueUuid, string $owner, ?string $ticketReference = null): bool
     {
         if ($this->db === null) {
             throw new RuntimeException('Cannot close the given issue, I have no DB connection');
         }
+        $uuid = Uuid::fromString($issueUuid);
         $db = $this->db;
         $issue = Issue::load($uuid->getBytes(), $db);
         $issue->set('status', 'acknowledged');

Original file line number	Diff line number	Diff line change
`@@ -100,11 +100,12 @@ protected function close(UuidInterface $uuid, $reason, $closedBy = null): bool`
`100`	`100`	`* @param string $ticketReference`
`101`	`101`	`* @return bool`
`102`	`102`	`*/`
`103`		`- protected function acknowledge(UuidInterface $uuid, string $owner, ?string $ticketReference = null): bool`
	`103`	`+ public function acknowledgeRequest(string $issueUuid, string $owner, ?string $ticketReference = null): bool`
`104`	`104`	`{`
`105`	`105`	`if ($this->db === null) {`
`106`	`106`	`throw new RuntimeException('Cannot close the given issue, I have no DB connection');`
`107`	`107`	`}`
	`108`	`+ $uuid = Uuid::fromString($issueUuid);`
`108`	`109`	`$db = $this->db;`
`109`	`110`	`$issue = Issue::load($uuid->getBytes(), $db);`
`110`	`111`	`$issue->set('status', 'acknowledged');`