Address feedback

Author: ThomsonTan

exporters/fluentd/CMakeLists.txt

@@ -63,6 +63,10 @@ endif()
 # create fluentd trace exporter
 add_library(opentelemetry_exporter_geneva_trace src/trace/fluentd_exporter.cc
                                                 src/trace/recordable.cc)
+set_target_properties(
+  opentelemetry_exporter_geneva_trace
+  PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_trace)
+
 if(MAIN_PROJECT)
   target_include_directories(opentelemetry_exporter_geneva_trace
                            PRIVATE ${OPENTELEMETRY_CPP_INCLUDE_DIRS})
@@ -83,6 +87,10 @@ endif()
 
 add_library(opentelemetry_exporter_geneva_logs src/log/fluentd_exporter.cc
                                                src/log/recordable.cc)
+set_target_properties(
+  opentelemetry_exporter_geneva_logs
+  PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_logs)
+
 if(MAIN_PROJECT)
   target_include_directories(opentelemetry_exporter_geneva_logs
                            PRIVATE ${OPENTELEMETRY_CPP_INCLUDE_DIRS})
@@ -117,14 +125,6 @@ if (WITH_EXAMPLES)
 endif()
 
 if(OPENTELEMETRY_INSTALL)
-  set_target_properties(
-    opentelemetry_exporter_geneva_trace
-    PROPERTIES
-      EXPORT_NAME opentelemetry_exporter_geneva_trace)
-  set_target_properties(
-    opentelemetry_exporter_geneva_logs
-    PROPERTIES
-      EXPORT_NAME opentelemetry_exporter_geneva_logs)
   if(MAIN_PROJECT)
     install(
       TARGETS opentelemetry_exporter_geneva_logs

exporters/geneva-trace/CMakeLists.txt

@@ -17,26 +17,26 @@ target_include_directories(
   opentelemetry_exporter_geneva_trace INTERFACE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
   $<INSTALL_INTERFACE:include>)
+set_target_properties(
+  opentelemetry_exporter_geneva_trace
+  PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_trace)
 
 add_library(opentelemetry_exporter_geneva_logs INTERFACE)
 target_include_directories(
   opentelemetry_exporter_geneva_logs INTERFACE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
   $<INSTALL_INTERFACE:include>)
+set_target_properties(
+  opentelemetry_exporter_geneva_logs
+  PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_logs)
+
 
 if(WITH_EXAMPLES)
   include_directories(include)
   add_subdirectory(example)
 endif()
 
 if(OPENTELEMETRY_INSTALL)
-  set_target_properties(
-    opentelemetry_exporter_geneva_trace
-    PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_trace)
-  set_target_properties(
-    opentelemetry_exporter_geneva_logs
-    PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_logs)
-
   if(MAIN_PROJECT)
     install(DIRECTORY include/ DESTINATION include)
 

exporters/geneva/CMakeLists.txt

@@ -44,6 +44,10 @@ else()
               src/exporter.cc src/unix_domain_socket_data_transport.cc)
 endif()
 
+set_target_properties(
+  opentelemetry_exporter_geneva_metrics
+  PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_metrics)
+
 if(MAIN_PROJECT)
    target_include_directories(opentelemetry_exporter_geneva_metrics
                       PRIVATE ${OPENTELEMETRY_CPP_INCLUDE_DIRS})
@@ -91,9 +95,6 @@ if(BUILD_TESTING)
 endif()
 
 if(OPENTELEMETRY_INSTALL)
-  set_target_properties(
-    opentelemetry_exporter_geneva_metrics
-    PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_metrics)
   if(MAIN_PROJECT)
     install(
       TARGETS opentelemetry_exporter_geneva_metrics