Skip to content

Commit 2c21a2d

Browse files
committed
[Geneva] Do not send to socket if it is invalid
1 parent 3521645 commit 2c21a2d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

exporters/geneva/src/unix_domain_socket_data_transport.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ bool UnixDomainSocketDataTransport::Send(MetricsEventType event_type,
4545
if (error_code != 0) {
4646
LOG_ERROR("Geneva Exporter: UDS::Send failed - not connected");
4747
connected_ = false;
48+
return false;
4849
}
4950

5051
// try to write
5152
size_t sent_size = socket_.writeall(data, length);
52-
if (length == sent_size) {
53-
// Disconnect();
54-
return true;
55-
} else {
53+
if (length != sent_size) {
54+
Disconnect();
5655
LOG_ERROR("Geneva Exporter: UDS::Send failed");
56+
return false;
5757
}
58-
return false;
58+
return true;
5959
}
6060

6161
bool UnixDomainSocketDataTransport::Disconnect() noexcept {

0 commit comments

Comments
 (0)