Skip to content

Commit 3a074f5

Browse files
committed
[Geneva] Make EXPORT_NAME consistent
1 parent f6df898 commit 3a074f5

File tree

4 files changed

+66
-70
lines changed

4 files changed

+66
-70
lines changed

exporters/fluentd/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,14 @@ if (WITH_EXAMPLES)
117117
endif()
118118

119119
if(OPENTELEMETRY_INSTALL)
120+
set_target_properties(
121+
opentelemetry_exporter_geneva_trace
122+
PROPERTIES
123+
EXPORT_NAME opentelemetry_exporter_geneva_trace)
124+
set_target_properties(
125+
opentelemetry_exporter_geneva_logs
126+
PROPERTIES
127+
EXPORT_NAME opentelemetry_exporter_geneva_logs)
120128
if(MAIN_PROJECT)
121129
install(
122130
TARGETS opentelemetry_exporter_geneva_logs
@@ -132,14 +140,6 @@ if(OPENTELEMETRY_INSTALL)
132140
FILES_MATCHING
133141
PATTERN "*.h")
134142
else()
135-
set_target_properties(
136-
opentelemetry_exporter_geneva_trace
137-
PROPERTIES
138-
EXPORT_NAME opentelemetry_exporter_geneva_trace)
139-
set_target_properties(
140-
opentelemetry_exporter_geneva_logs
141-
PROPERTIES
142-
EXPORT_NAME opentelemetry_exporter_geneva_logs)
143143
otel_add_component(
144144
COMPONENT
145145
exporters_geneva_fluentd

exporters/geneva-trace/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,13 @@ if(WITH_EXAMPLES)
3030
endif()
3131

3232
if(OPENTELEMETRY_INSTALL)
33+
set_target_properties(
34+
opentelemetry_exporter_geneva_trace
35+
PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_trace)
36+
set_target_properties(
37+
opentelemetry_exporter_geneva_logs
38+
PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_logs)
39+
3340
if(MAIN_PROJECT)
3441
install(DIRECTORY include/ DESTINATION include)
3542

@@ -44,13 +51,6 @@ if(OPENTELEMETRY_INSTALL)
4451
DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}")
4552
endif()
4653
else()
47-
set_target_properties(
48-
opentelemetry_exporter_geneva_trace
49-
PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_trace)
50-
set_target_properties(
51-
opentelemetry_exporter_geneva_logs
52-
PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_logs)
53-
5454
otel_add_component(
5555
COMPONENT
5656
exporters_geneva_trace_logs
@@ -60,7 +60,7 @@ if(OPENTELEMETRY_INSTALL)
6060
FILES_DIRECTORY
6161
"include/opentelemetry/exporters/geneva"
6262
FILES_DESTINATION
63-
"include/opentelemetry/exporters/geneva"
63+
"include/opentelemetry/exporters"
6464
FILES_MATCHING
6565
PATTERN
6666
"*.h")

exporters/geneva/CMakeLists.txt

Lines changed: 29 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -91,40 +91,36 @@ if(BUILD_TESTING)
9191
endif()
9292

9393
if(OPENTELEMETRY_INSTALL)
94-
95-
if(MAIN_PROJECT)
96-
97-
install(
98-
TARGETS opentelemetry_exporter_geneva_metrics
99-
EXPORT "${PROJECT_NAME}-target"
100-
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
101-
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
102-
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
103-
104-
install(
105-
DIRECTORY include/opentelemetry/exporters/geneva
106-
DESTINATION include/opentelemetry/exporters
107-
FILES_MATCHING
108-
PATTERN "*.h")
109-
110-
else()
111-
112-
set_target_properties(opentelemetry_exporter_geneva_metrics PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_metrics)
113-
114-
otel_add_component(
115-
COMPONENT
116-
exporters_geneva_metrics
117-
TARGETS
94+
set_targt_properties(
11895
opentelemetry_exporter_geneva_metrics
119-
FILES_DIRECTORY
120-
"include/opentelemetry/exporters/geneva"
121-
FILES_DESTINATION
122-
"include/opentelemetry/exporters"
123-
FILES_MATCHING
124-
PATTERN
125-
"*.h")
126-
127-
endif()
96+
PROPERTIES EXPORT_NAME opentelemetry_exporter_geneva_metrics)
97+
if(MAIN_PROJECT)
98+
install(
99+
TARGETS opentelemetry_exporter_geneva_metrics
100+
EXPORT "${PROJECT_NAME}-target"
101+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
102+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
103+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
104+
105+
install(
106+
DIRECTORY include/opentelemetry/exporters/geneva
107+
DESTINATION include/opentelemetry/exporters
108+
FILES_MATCHING
109+
PATTERN "*.h")
110+
else()
111+
otel_add_component(
112+
COMPONENT
113+
exporters_geneva_metrics
114+
TARGETS
115+
opentelemetry_exporter_geneva_metrics
116+
FILES_DIRECTORY
117+
"include/opentelemetry/exporters/geneva"
118+
FILES_DESTINATION
119+
"include/opentelemetry/exporters"
120+
FILES_MATCHING
121+
PATTERN
122+
"*.h")
123+
endif()
128124
endif()
129125

130126
if(WITH_EXAMPLES)

exporters/user_events/CMakeLists.txt

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -136,29 +136,29 @@ if(WITH_BENCHMARK)
136136
opentelemetry_exporter_user_events_logs)
137137
endif()
138138

139-
if(MAIN_PROJECT)
139+
set_target_properties(
140+
opentelemetry_exporter_user_events_logs
141+
PROPERTIES
142+
EXPORT_NAME opentelemetry_exporter_user_events_logs)
143+
set_target_properties(
144+
opentelemetry_exporter_user_events_metrics
145+
PROPERTIES
146+
EXPORT_NAME opentelemetry_exporter_user_events_metrics)
140147

141-
install(
142-
TARGETS opentelemetry_exporter_user_events_logs
143-
EXPORT "${PROJECT_NAME}-target"
144-
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
145-
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
146-
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
147-
148-
install(
149-
DIRECTORY include/opentelemetry/exporters/user_events
150-
DESTINATION include/opentelemetry/exporters
151-
FILES_MATCHING
152-
PATTERN "*.h")
148+
if(MAIN_PROJECT)
149+
install(
150+
TARGETS opentelemetry_exporter_user_events_logs
151+
EXPORT "${PROJECT_NAME}-target"
152+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
153+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
154+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
155+
156+
install(
157+
DIRECTORY include/opentelemetry/exporters/user_events
158+
DESTINATION include/opentelemetry/exporters
159+
FILES_MATCHING
160+
PATTERN "*.h")
153161
else()
154-
set_target_properties(
155-
opentelemetry_exporter_user_events_logs
156-
PROPERTIES
157-
EXPORT_NAME opentelemetry_exporter_user_events_logs)
158-
set_target_properties(
159-
opentelemetry_exporter_user_events_metrics
160-
PROPERTIES
161-
EXPORT_NAME opentelemetry_exporter_user_events_metrics)
162162
otel_add_component(
163163
COMPONENT
164164
exporters_user_events

0 commit comments

Comments
 (0)