resolve socket leak in fluentd exporter (open-telemetry#585)

KSSKarthikeya · web-flow · commit 78e2a71a42e0 · 2025-10-03T13:54:52.000-07:00
diff --git a/exporters/fluentd/src/log/fluentd_exporter.cc b/exporters/fluentd/src/log/fluentd_exporter.cc
@@ -169,6 +169,10 @@ bool FluentdExporter::Connect() {
     connected_ = socket_.connect(*addr_);
     if (!connected_) {
       LOG_ERROR("Unable to connect to %s", options_.endpoint.c_str());
+      // Close the socket to avoid leaking file descriptors on failure.
+      if (!socket_.invalid()) {
+        socket_.close();
+      }
       return false;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,10 @@ bool FluentdExporter::Connect() {`
`169`	`169`	`connected_ = socket_.connect(*addr_);`
`170`	`170`	`if (!connected_) {`
`171`	`171`	`LOG_ERROR("Unable to connect to %s", options_.endpoint.c_str());`
	`172`	`+ // Close the socket to avoid leaking file descriptors on failure.`
	`173`	`+ if (!socket_.invalid()) {`
	`174`	`+ socket_.close();`
	`175`	`+ }`
`172`	`176`	`return false;`
`173`	`177`	`}`
`174`	`178`	`}`