[Geneva] Fix missing close when connecting failed (open-telemetry#548)

ThomsonTan · web-flow · commit 8dea0c044eb5 · 2025-05-06T11:32:00.000-07:00
diff --git a/exporters/geneva/src/socket_data_transport.cc b/exporters/geneva/src/socket_data_transport.cc
@@ -36,11 +36,11 @@ bool SocketDataTransport::Connect() noexcept {
     socket_ = SocketTools::Socket(socketparams_);
     connected_ = socket_.connect(*addr_);
     if (!connected_) {
+      socket_.close();
       LOG_ERROR("Geneva Exporter: UDS::Connect failed");
-      return false;
     }
   }
-  return true;
+  return connected_;
 }
 
 bool SocketDataTransport::Send(MetricsEventType event_type,

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,11 @@ bool SocketDataTransport::Connect() noexcept {`
`36`	`36`	`socket_ = SocketTools::Socket(socketparams_);`
`37`	`37`	`connected_ = socket_.connect(*addr_);`
`38`	`38`	`if (!connected_) {`
	`39`	`+ socket_.close();`
`39`	`40`	`LOG_ERROR("Geneva Exporter: UDS::Connect failed");`
`40`		`- return false;`
`41`	`41`	`}`
`42`	`42`	`}`
`43`		`- return true;`
	`43`	`+ return connected_;`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`bool SocketDataTransport::Send(MetricsEventType event_type,`