Skip to content

Commit d4ee4ac

Browse files
authored
Merge branch 'main' into update_user_events_deps
2 parents 075d946 + a4d3681 commit d4ee4ac

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

.github/workflows/nginx.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
fail-fast: false
4747
matrix:
4848
image: ["ubuntu:24.04", "debian:11", "alpine:3.20", "amazonlinux:2", "amazonlinux:2023"]
49-
nginx: ["1.27.3", "1.27.1", "1.26.2", "1.24.0", "1.22.1"]
49+
nginx: ["1.27.3", "1.27.2", "1.27.1", "1.26.2", "1.24.0", "1.22.1"]
5050
steps:
5151
- name: checkout otel nginx
5252
uses: actions/checkout@v4

exporters/geneva/src/exporter.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33

44
#include "opentelemetry/exporters/geneva/metrics/exporter.h"
55
#include "opentelemetry/exporters/geneva/metrics/macros.h"
6-
#include "opentelemetry/exporters/geneva/metrics/unix_domain_socket_data_transport.h"
76
#ifdef _WIN32
87
#include "opentelemetry/exporters/geneva/metrics/etw_data_transport.h"
8+
#else
9+
#include "opentelemetry/exporters/geneva/metrics/unix_domain_socket_data_transport.h"
910
#endif
1011
#include "opentelemetry/sdk/metrics/export/metric_producer.h"
1112
#include "opentelemetry/sdk_config.h"

exporters/user_events/include/opentelemetry/exporters/user_events/logs/exporter.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ class Exporter final : public opentelemetry::sdk::logs::LogRecordExporter
4242
bool Shutdown(
4343
std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override;
4444

45+
bool ForceFlush(
46+
std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override {
47+
// TODO: implement forceflush
48+
return true;
49+
}
50+
4551
bool isShutdown() const noexcept;
4652

4753
private:

exporters/user_events/src/recordable.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ void Recordable::SetBody(const opentelemetry::common::AttributeValue &message) n
4848
// Set intial bookmark size to 1 for body below.
4949
cs_part_b_bookmark_size_++;
5050
event_builder_.AddStruct("PartB", 1, 0, &cs_part_b_bookmark_);
51+
utils::PopulateAttribute("_typeName", "Log", event_builder_);
5152
utils::PopulateAttribute("body", message, event_builder_);
5253
}
5354

instrumentation/nginx/test/Dockerfile_amazonlinux

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ FROM $image AS build
44
ARG otel_cpp_version=1.17.0
55
ARG nginx_version=1.27.3
66

7-
RUN yum check-update && \
8-
yum install -y git gcc-c++ make tar curl-devel unzip zlib-devel pcre2-devel
7+
RUN yum install -y git gcc-c++ make tar curl-devel unzip zlib-devel pcre2-devel
98

109
RUN curl -LO https://github.com/Kitware/CMake/releases/download/v3.31.1/cmake-3.31.1-linux-x86_64.tar.gz && tar xf cmake-3.31.1-linux-x86_64.tar.gz && mv cmake-3.31.1-linux-x86_64 cmake
1110

0 commit comments

Comments
 (0)