[Geneva] close valid socket on disconnection (open-telemetry#544)

ThomsonTan · web-flow · commit ec52a14e863b · 2025-04-15T13:35:17.000-07:00
diff --git a/exporters/geneva/src/socket_data_transport.cc b/exporters/geneva/src/socket_data_transport.cc
@@ -77,7 +77,7 @@ bool SocketDataTransport::Send(MetricsEventType event_type,
 bool SocketDataTransport::Disconnect() noexcept {
   if (connected_) {
     connected_ = false;
-    if (socket_.invalid()) {
+    if (!socket_.invalid()) {
       socket_.close();
       return true;
     }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ bool SocketDataTransport::Send(MetricsEventType event_type,`
`77`	`77`	`bool SocketDataTransport::Disconnect() noexcept {`
`78`	`78`	`if (connected_) {`
`79`	`79`	`connected_ = false;`
`80`		`- if (socket_.invalid()) {`
	`80`	`+ if (!socket_.invalid()) {`
`81`	`81`	`socket_.close();`
`82`	`82`	`return true;`
`83`	`83`	`}`