Skip to content

Commit 3255162

Browse files
committed
wip tests failing
1 parent 6eed692 commit 3255162

19 files changed

+1103
-1067
lines changed
Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
1-
namespace Ocelot.Provider.Eureka
2-
{
3-
using ServiceDiscovery.Providers;
4-
using Steeltoe.Common.Discovery;
5-
using System.Collections.Generic;
6-
using System.Linq;
7-
using System.Threading.Tasks;
8-
using Values;
9-
10-
public class Eureka : IServiceDiscoveryProvider
11-
{
12-
private readonly IDiscoveryClient _client;
13-
private readonly string _serviceName;
14-
15-
public Eureka(string serviceName, IDiscoveryClient client)
16-
{
17-
_client = client;
18-
_serviceName = serviceName;
19-
}
20-
21-
public Task<List<Service>> Get()
22-
{
23-
var services = new List<Service>();
24-
25-
var instances = _client.GetInstances(_serviceName);
26-
27-
if (instances != null && instances.Any())
28-
{
29-
services.AddRange(instances.Select(i => new Service(i.ServiceId, new ServiceHostAndPort(i.Host, i.Port, i.Uri.Scheme), "", "", new List<string>())));
30-
}
31-
32-
return Task.FromResult(services);
33-
}
34-
}
35-
}
1+
namespace Ocelot.Provider.Eureka
2+
{
3+
using Ocelot.ServiceDiscovery.Providers;
4+
using Steeltoe.Discovery;
5+
using System.Collections.Generic;
6+
using System.Linq;
7+
using System.Threading.Tasks;
8+
using Ocelot.Values;
9+
10+
public class Eureka : IServiceDiscoveryProvider
11+
{
12+
private readonly IDiscoveryClient _client;
13+
private readonly string _serviceName;
14+
15+
public Eureka(string serviceName, IDiscoveryClient client)
16+
{
17+
_client = client;
18+
_serviceName = serviceName;
19+
}
20+
21+
public Task<List<Service>> Get()
22+
{
23+
var services = new List<Service>();
24+
25+
var instances = _client.GetInstances(_serviceName);
26+
27+
if (instances != null && instances.Any())
28+
{
29+
services.AddRange(instances.Select(i => new Service(i.ServiceId, new ServiceHostAndPort(i.Host, i.Port, i.Uri.Scheme), "", "", new List<string>())));
30+
}
31+
32+
return Task.FromResult(services);
33+
}
34+
}
35+
}

src/Ocelot.Provider.Eureka/EurekaProviderFactory.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
namespace Ocelot.Provider.Eureka
22
{
33
using Microsoft.Extensions.DependencyInjection;
4-
using ServiceDiscovery;
5-
using Steeltoe.Common.Discovery;
6-
4+
using Ocelot.ServiceDiscovery;
5+
using Steeltoe.Discovery;
6+
77
public static class EurekaProviderFactory
88
{
99
public static ServiceDiscoveryFinderDelegate Get = (provider, config, route) =>

src/Ocelot.Provider.Eureka/Ocelot.Provider.Eureka.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<ProjectReference Include="..\Ocelot\Ocelot.csproj" />
2828
</ItemGroup>
2929
<ItemGroup>
30-
<PackageReference Include="Steeltoe.Discovery.ClientCore" Version="2.4.2" />
30+
<PackageReference Include="Steeltoe.Discovery.ClientCore" Version="3.0.1" />
3131
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.164">
3232
<PrivateAssets>all</PrivateAssets>
3333
</PackageReference>

test/Ocelot.AcceptanceTests/ClaimsToDownstreamPathTests.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,13 @@ public void should_return_200_and_change_downstream_path()
9696
.When(x => _steps.WhenIGetUrlOnTheApiGateway("/users"))
9797
.Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.OK))
9898
.And(x => _steps.ThenTheResponseBodyShouldBe("UserId: 1231231"))
99-
.And(x => _downstreamFinalPath.ShouldBe("/users/1231231"))
99+
.And(x => ThenTheDownstreamPathIs("/users/1231231"))
100100
.BDDfy();
101+
}
102+
103+
private void ThenTheDownstreamPathIs(string path)
104+
{
105+
_downstreamFinalPath.ShouldBe(path);
101106
}
102107

103108
private void GivenThereIsAServiceRunningOn(string url, int statusCode)

0 commit comments

Comments
 (0)