removed old memory cache and added a few tests for new asp memory cache

Author: TomPallister

src/Ocelot/Cache/AspMemoryCache.cs

@@ -1,11 +1,9 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using Microsoft.Extensions.Caching.Distributed;
-using Microsoft.Extensions.Caching.Memory;
-
-namespace Ocelot.Cache
+namespace Ocelot.Cache
 {
+    using System;
+    using System.Collections.Generic;
+    using Microsoft.Extensions.Caching.Memory;
+
     public class AspMemoryCache<T> : IOcelotCache<T>
     {
         private readonly IMemoryCache _memoryCache;
@@ -20,18 +18,23 @@ public AspMemoryCache(IMemoryCache memoryCache)
         public void Add(string key, T value, TimeSpan ttl, string region)
         {
             if (ttl.TotalMilliseconds <= 0)
+            {
                 return;
+            }
 
             _memoryCache.Set(key, value, ttl);
 
             SetRegion(region, key);
         }
 
         public T Get(string key, string region)
-        {
-            _memoryCache.TryGetValue<T>(key, out T value);
+        {   
+            if (_memoryCache.TryGetValue(key, out T value))
+            {
+                return value;
+            }
 
-            return value;
+            return default(T);
         }
 
         public void ClearRegion(string region)
@@ -48,8 +51,10 @@ public void ClearRegion(string region)
 
         public void AddAndDelete(string key, T value, TimeSpan ttl, string region)
         {
-            if (_memoryCache.TryGetValue(key, out object oldValue))
+            if (_memoryCache.TryGetValue(key, out T oldValue))
+            {
                 _memoryCache.Remove(key);
+            }
 
             Add(key, value, ttl, region);
         }

src/Ocelot/Cache/InMemoryCache.cs

@@ -77,20 +77,6 @@ private void SetHttpResponseMessageThisRequest(DownstreamContext context,
             context.DownstreamResponse = response;
         }
 
-        private string GenerateRequestCacheKey(DownstreamContext context)
-        {
-            string hashedContent = null;
-            StringBuilder downStreamUrlKeyBuilder = new StringBuilder($"{context.DownstreamRequest.Method}-{context.DownstreamRequest.OriginalString}");
-            if (context.DownstreamRequest.Content != null)
-            {
-                string requestContentString = Task.Run(async () => await context.DownstreamRequest.Content?.ReadAsStringAsync()).Result;
-                downStreamUrlKeyBuilder.Append(requestContentString);
-            }
-
-            hashedContent = MD5Helper.GenerateMd5(downStreamUrlKeyBuilder.ToString());
-            return hashedContent;
-        }
-
         internal DownstreamResponse CreateHttpResponseMessage(CachedResponse cached)
         {
             if (cached == null)

src/Ocelot/Cache/Middleware/OutputCacheMiddleware.cs

@@ -1,7 +1,3 @@
-using Ocelot.ServiceDiscovery.Providers;
-
-using Ocelot.Configuration.ChangeTracking;
-
 namespace Ocelot.DependencyInjection
 {
     using Microsoft.AspNetCore.Http;
@@ -13,6 +9,8 @@ namespace Ocelot.DependencyInjection
     using Ocelot.Cache;
     using Ocelot.Claims;
     using Ocelot.Configuration;
+    using Ocelot.ServiceDiscovery.Providers;
+    using Ocelot.Configuration.ChangeTracking;
     using Ocelot.Configuration.Creator;
     using Ocelot.Configuration.File;
     using Ocelot.Configuration.Parser;
@@ -58,12 +56,8 @@ public OcelotBuilder(IServiceCollection services, IConfiguration configurationRo
             Services = services;
             Services.Configure<FileConfiguration>(configurationRoot);
 
-            //Services.TryAddSingleton<IOcelotCache<FileConfiguration>, InMemoryCache<FileConfiguration>>();
-            //Services.TryAddSingleton<IOcelotCache<CachedResponse>, InMemoryCache<CachedResponse>>();
             Services.TryAddSingleton<IOcelotCache<FileConfiguration>, AspMemoryCache<FileConfiguration>>();
             Services.TryAddSingleton<IOcelotCache<CachedResponse>, AspMemoryCache<CachedResponse>>();
-
-
             Services.TryAddSingleton<IHttpResponseHeaderReplacer, HttpResponseHeaderReplacer>();
             Services.TryAddSingleton<IHttpContextRequestHeaderReplacer, HttpContextRequestHeaderReplacer>();
             Services.TryAddSingleton<IHeaderFindAndReplaceCreator, HeaderFindAndReplaceCreator>();

src/Ocelot/DependencyInjection/OcelotBuilder.cs

@@ -1,12 +1,11 @@
-using Microsoft.Extensions.Caching.Memory;
-
-namespace Ocelot.UnitTests.Cache
+namespace Ocelot.UnitTests.Cache
 {
     using Ocelot.Cache;
     using Shouldly;
     using System;
     using System.Threading;
     using Xunit;
+    using Microsoft.Extensions.Caching.Memory;
 
     public class AspMemoryCacheTests
     {
@@ -27,6 +26,13 @@ public void should_cache()
             fake.Value.ShouldBe(1);
         }
 
+        [Fact]
+        public void doesnt_exist()
+        {
+            var result = _cache.Get("1", "region");
+            result.ShouldBeNull();
+        }
+
         [Fact]
         public void should_add_and_delete()
         {
@@ -42,11 +48,15 @@ public void should_add_and_delete()
         [Fact]
         public void should_clear_region()
         {
-            var fake = new Fake(1);
-            _cache.Add("1", fake, TimeSpan.FromSeconds(100), "region");
+            var fake1 = new Fake(1);
+            var fake2 = new Fake(2);
+            _cache.Add("1", fake1, TimeSpan.FromSeconds(100), "region");
+            _cache.Add("2", fake2, TimeSpan.FromSeconds(100), "region");
             _cache.ClearRegion("region");
-            var result = _cache.Get("1", "region");
-            result.ShouldBeNull();
+            var result1 = _cache.Get("1", "region");
+            result1.ShouldBeNull();
+            var result2 = _cache.Get("2", "region");
+            result2.ShouldBeNull();
         }
 
         [Fact]

test/Ocelot.UnitTests/Cache/AspMemoryCacheTests.cs

@@ -3,8 +3,8 @@
     using global::CacheManager.Core;
     using Moq;
     using Ocelot.Cache.CacheManager;
-    using Shouldly;
     using System;
+    using Shouldly;
     using TestStack.BDDfy;
     using Xunit;