#603 return 502 when request cannot be completed

Author: jlukawska

src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs

@@ -42,7 +42,7 @@ public int Map(List<Error> errors)
 
             if (errors.Any(e => e.Code == OcelotErrorCode.UnableToCompleteRequestError))
             {
-                return 500;
+                return 502;
             }
 
             return 404;

test/Ocelot.AcceptanceTests/ReturnsErrorTests.cs

@@ -16,6 +16,38 @@ public ReturnsErrorTests()
         {
             _serviceHandler = new ServiceHandler();
             _steps = new Steps();
+        }
+
+        [Fact]
+        public void should_return_bad_gateway_error_if_downstream_service_doesnt_respond()
+        {
+            var configuration = new FileConfiguration
+            {
+                ReRoutes = new List<FileReRoute>
+                    {
+                        new FileReRoute
+                        {
+                            DownstreamPathTemplate = "/",
+                            UpstreamPathTemplate = "/",
+                            UpstreamHttpMethod = new List<string> { "Get" },
+                            DownstreamHostAndPorts = new List<FileHostAndPort>
+                            {
+                                new FileHostAndPort
+                                {
+                                    Host = "localhost",
+                                    Port = 53876,
+                                },
+                            },
+                            DownstreamScheme = "http",
+                        },
+                    },
+            };
+
+            this.Given(x => _steps.GivenThereIsAConfiguration(configuration))
+                .And(x => _steps.GivenOcelotIsRunning())
+                .When(x => _steps.WhenIGetUrlOnTheApiGateway("/"))
+                .Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.BadGateway))
+                .BDDfy();
         }
 
         [Fact]

test/Ocelot.AcceptanceTests/SslTests.cs

@@ -89,7 +89,7 @@ public void should_not_dangerous_accept_any_server_certificate_validator()
                 .And(x => _steps.GivenThereIsAConfiguration(configuration))
                 .And(x => _steps.GivenOcelotIsRunning())
                 .When(x => _steps.WhenIGetUrlOnTheApiGateway("/"))
-                .Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.InternalServerError))
+                .Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.BadGateway))
                 .BDDfy();
         }
 

test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs

@@ -47,9 +47,9 @@ public void should_return_service_unavailable(OcelotErrorCode errorCode)
 
         [Theory]
         [InlineData(OcelotErrorCode.UnableToCompleteRequestError)]
-        public void should_return_internal_server_error(OcelotErrorCode errorCode)
+        public void should_return_bad_gateway_error(OcelotErrorCode errorCode)
         {
-            ShouldMapErrorToStatusCode(errorCode, HttpStatusCode.InternalServerError);
+            ShouldMapErrorToStatusCode(errorCode, HttpStatusCode.BadGateway);
         }
 
         [Theory]