Unsupported chars in placeholder name

[ggnaegi]

Expected Behavior / New Feature

if "-" (hyphens) between the placeholders it should match

Actual Behavior / Motivation for New Feature

After having introduced the new solution the matching doesn't work when hyphens are found in the placeholders, eg: {"url-service-1"}

In fact, it's not possible to have hyphens as part of the regex group name, only alphanumerics and '_' (underscore) are allowed.

[raman-m]

I will write you in Slack.
I'm sad and wondered that the quality of this feature is not the same as we thought and expected.
Please explain and attach the logs with errors!

[ggnaegi]

Yes it's a sad thing because we have foreseen a lot of tests. The hyphen can't be used as regex group name caracter.

[raman-m]

Please make a decision: Would you prefer to categorize this issue as a bug or convert it to a feature?

In my opinion, we do not have a bug. However, we face due to the lack of instructions in the Placeholders documentation, where we must clarify to users which characters can be used in placeholder names. Currently, we support only alphanumeric characters along with the underscore character, _. Additionally, can utilize case sensitivity in placeholder names as it is case sensitive.

[ggnaegi]

@raman-m I will have a more in-depth analysis of the situation. I think, we should first wait for more feedbacks. In my case, we have decided to use camelCasing instead.

[raman-m]

In my case, we have decided to use Camel Casing instead.

Good, clever boys! In addition to camel case names, we can throw in digits and _ (underscore). These cover 99.99999999999% of developers, clients, and customers. But you, my friend, are lucky: you've got a deal with that elusive 0.0000000001% of customers! 🎉 🤣

I think, we should first wait for more feedbacks.

This issue should be opened, correct?
Additionally, should we updating the documentation to clarify allowed characters?

[ggnaegi]

This issue should be opened, correct? Additionally, should we updating the documentation to clarify allowed characters?

Yes and Yes

[ggnaegi]

By the way, standard behavior for routing in .NET -> word with hyphens, camelCase, eg. user-id -> userId. So maybe we should follow this logic, but it's not a bug, it's a feature.