Merge pull request #4 from Thundernerd/develop

Develop

Author: Thundernerd

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [1.1.2] - 2020-08-23
+
+###Added
+- Hiding warning 162 with pragma
+
+###Updated
+- var to explicit type
+- author name to TNRD
+
 ## [1.1.1] - 2020-08-19
 
 ### Fixed

Runtime/SafeEvent.cs

@@ -20,7 +20,7 @@ public void Invoke()
             if (subscriptions == null)
                 return;
 
-            foreach (var subscription in subscriptions)
+            foreach (Action subscription in subscriptions)
             {
 #if UNITY_EDITOR || DEBUG
                 ThrowIfInvalidSubscription(subscription);
@@ -59,7 +59,9 @@ public void Subscribe(Action action)
 #if UNITY_EDITOR || DEBUG
                 throw new DuplicateSubscriptionException();
 #endif
+#pragma warning disable 162
                 return;
+#pragma warning restore 162
             }
 
             subscriptions.Add(action);

Runtime/SafeEventOneParameter.cs

@@ -20,7 +20,7 @@ public void Invoke(T obj)
             if (subscriptions == null)
                 return;
 
-            foreach (var subscription in subscriptions)
+            foreach (Action<T> subscription in subscriptions)
             {
 #if UNITY_EDITOR || DEBUG
                 ThrowIfInvalidSubscription(subscription);
@@ -59,7 +59,9 @@ public void Subscribe(Action<T> action)
 #if UNITY_EDITOR || DEBUG
                 throw new DuplicateSubscriptionException();
 #endif
+#pragma warning disable 162
                 return;
+#pragma warning restore 162
             }
 
             subscriptions.Add(action);

Runtime/SafeEventTwoParameters.cs

@@ -20,7 +20,7 @@ public void Invoke(T arg1, T2 arg2)
             if (subscriptions == null)
                 return;
 
-            foreach (var subscription in subscriptions)
+            foreach (Action<T, T2> subscription in subscriptions)
             {
 #if UNITY_EDITOR || DEBUG
                 ThrowIfInvalidSubscription(subscription);
@@ -59,7 +59,9 @@ public void Subscribe(Action<T, T2> action)
 #if UNITY_EDITOR || DEBUG
                 throw new DuplicateSubscriptionException();
 #endif
+#pragma warning disable 162
                 return;
+#pragma warning restore 162
             }
 
             subscriptions.Add(action);

Tests/Runtime/SafeEventOneParameterTests.cs

@@ -9,8 +9,8 @@ public class SafeEventOneParameterTests
     [Test]
     public void Invoke_On_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -25,8 +25,8 @@ public void Invoke_On_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -51,8 +51,8 @@ public IEnumerator Invoke_On_Destroyed_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_GameObject()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);

Tests/Runtime/SafeEventTests.cs

@@ -9,8 +9,8 @@ public class SafeEventTests
     [Test]
     public void Invoke_On_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -23,8 +23,8 @@ public void Invoke_On_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -49,8 +49,8 @@ public IEnumerator Invoke_On_Destroyed_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_GameObject()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -75,8 +75,8 @@ public IEnumerator Invoke_On_Destroyed_GameObject()
     [UnityTest]
     public IEnumerator Dispatch_Exposed_Action()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
         yield return null;
 
         bool invoked = false;

Tests/Runtime/SafeEventTwoParametersTests.cs

@@ -9,8 +9,8 @@ public class SafeEventTwoParametersTests
     [Test]
     public void Invoke_On_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int, int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -27,8 +27,8 @@ public void Invoke_On_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_Behaviour()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int, int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);
@@ -53,8 +53,8 @@ public IEnumerator Invoke_On_Destroyed_Behaviour()
     [UnityTest]
     public IEnumerator Invoke_On_Destroyed_GameObject()
     {
-        var holder = new GameObject();
-        var dummyBehaviour = holder.AddComponent<DummyBehaviour>();
+        GameObject holder = new GameObject();
+        DummyBehaviour dummyBehaviour = holder.AddComponent<DummyBehaviour>();
 
         SafeEvent<int, int> sf;
         sf.Subscribe(dummyBehaviour.Dummy);

package.json

@@ -1,7 +1,7 @@
 {
   "name": "net.tnrd.safeevent",
   "displayName": "Safe Event",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "unity": "2019.1",
   "description": "An event class that has extra checks to help prevent mistakes",
   "keywords": [
@@ -17,7 +17,7 @@
     "issues"
   ],
   "author": {
-    "name": "Christiaan Bloemendaal",
+    "name": "TNRD",
     "email": "[email protected]",
     "url": "https://www.tnrd.net"
   },