Skip to content

Comments

Update Project.toml#160

Closed
rdboyes wants to merge 1 commit intomainfrom
rdboyes-patch-2
Closed

Update Project.toml#160
rdboyes wants to merge 1 commit intomainfrom
rdboyes-patch-2

Conversation

@rdboyes
Copy link
Member

@rdboyes rdboyes commented Mar 7, 2025

No description provided.

@drizk1
Copy link
Member

drizk1 commented Mar 8, 2025

I was peeking around, and Tplots has TidierData = ".16" which might need to be expanded ? But compats always fool me so I could be wrong

@rdboyes
Copy link
Member Author

rdboyes commented Mar 8, 2025

I think it's ok for now? 0.16.5 is the latest version and that counts as "0.16" as far as I know. Some of these issues will go away once we are using post-1.0 versions

@kdpsingh
Copy link
Member

kdpsingh commented Mar 8, 2025

Thanks @rdboyes for this PR. Going to merge some PRs this weekend and early next week. Have a question on this compat for TidierPlots: "0.9, 0.10, 0.11, 0.12, 1"

Do we need to keep the older versions listed here (e.g., 0.9) in order for Tidier to be compatible with the pre-installed version of Makie that comes with Colab?

In general, I've been trying to keep only the newest minor versionfor the base packages in the Tidier compat so that when users update Tidier, all the base packages are automatically updated to their latest versions. If we keep older versions of TidierPlots in the compat, then updating Tidier won't necessarily updated TidierPlots.

If we need to keep the older versions for the purposes of Colab, then I think we should leave the older versions in. Otherwise, would keep only the latest version. Thanks, and happy to discuss offline on Slack if worth a conversation.

@rdboyes
Copy link
Member Author

rdboyes commented Mar 9, 2025

I'm fine with having only the newest version listed. My understanding is that the package manager will install the most recent version that it can, so the only cases where we would get older versions of TidierPlots with this compat are ones that would fail to resolve if the compat said just "0.11". I added 0.12 in there just for future proofing - It should do nothing until I actually release 0.12

@kdpsingh
Copy link
Member

kdpsingh commented Mar 9, 2025

Thanks.

I can test this, but if you already have an older version of TidierPlots, TidierData, etc, installed, will updating Tidier force upgrades on the base packages if the older versions meet the compat requirements?

@kdpsingh
Copy link
Member

Thanks for prepping this. Going to close this as I have a separate PR which includes all the latest package versions based on the latest version updates.

@kdpsingh kdpsingh closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants