Skip to content

Comments

Refactor of Athena functions#151

Merged
drizk1 merged 2 commits intoTidierOrg:mainfrom
AbrJA:main
Aug 7, 2025
Merged

Refactor of Athena functions#151
drizk1 merged 2 commits intoTidierOrg:mainfrom
AbrJA:main

Conversation

@AbrJA
Copy link
Contributor

@AbrJA AbrJA commented Aug 6, 2025

  • Fix for queries without results (it throwed an error and now a dataset with 0 rows is returned)
  • Apply exponential backoff for calling the AWS API
  • Simply the logic for collecting Athena results

Any comment or clarification we can talk about it!

@drizk1
Copy link
Member

drizk1 commented Aug 6, 2025

This PR is much appreciated.

Just wondering what does the "exponential back off" mean

@AbrJA
Copy link
Contributor Author

AbrJA commented Aug 6, 2025

Exponential backoff is a retry strategy where a client waits progressively longer intervals before resubmitting a request. In this case the waiting period starts in 1 sec and it grows until 10 secs (by a factor of 1.2) if the query takes so much to run (more than 1 minute)

@drizk1
Copy link
Member

drizk1 commented Aug 7, 2025

Yea that's awesome.

Your help on the aws backend was very needed. Will have this merged and released soon

Are you a regular aws user? Open to any other suggestions/improvements you might have

@AbrJA
Copy link
Contributor Author

AbrJA commented Aug 7, 2025

Thanks to you @drizk1 for all the work in this amazing package!
I'll continue to use it and if I find anything relevant, I'll share it with you.

@drizk1 drizk1 merged commit ed77af1 into TidierOrg:main Aug 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants