Correct Disable Pandas Testing for GHA Nightly Builds (#966)

* Remove Mixed Space/Tabs in GHA Daily Test YAML

* Fix Files in `text_examples` For Both Windows And Linux Paths

* Readdition of #on: [push]

This line is not necessary but is convenient when debugging.

Author: nguyenv

.github/workflows/daily-test-build.yml

@@ -11,24 +11,24 @@ jobs:
   test-wheels-on-azure:
     runs-on: ubuntu-latest
     steps:
-    - name: Get current date
-      id: date
-      run: echo "::set-output name=date::$(date +'%a-%Y-%m-%d')"
-    - name: Get libtiledb short SHA
-      run: echo "LIBTILEDB_SHA=$(git ls-remote https://github.com/TileDB-Inc/TileDB HEAD | cut -c1-7)" >> $GITHUB_ENV
-    - name: Create Test Branch for Azure Wheel Nightly Build
-      uses: peterjgrainger/[email protected]
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        branch: 'azure-wheel-test-${{ steps.date.outputs.date }}-against-${{ env.LIBTILEDB_SHA }}'
+      - name: Get current date
+        id: date
+        run: echo "::set-output name=date::$(date +'%a-%Y-%m-%d')"
+      - name: Get libtiledb short SHA
+        run: echo "LIBTILEDB_SHA=$(git ls-remote https://github.com/TileDB-Inc/TileDB HEAD | cut -c1-7)" >> $GITHUB_ENV
+      - name: Create Test Branch for Azure Wheel Nightly Build
+        uses: peterjgrainger/[email protected]
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          branch: "azure-wheel-test-${{ steps.date.outputs.date }}-against-${{ env.LIBTILEDB_SHA }}"
 
   test:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [ubuntu-latest, macos-10.15, windows-latest]
-	uninstall_pandas: [true, false]
+        uninstall_pandas: [true, false]
 
     permissions:
       issues: write
@@ -37,46 +37,46 @@ jobs:
       MACOSX_DEPLOYMENT_TARGET: 10.14
 
     steps:
-    - name: Set up Python
-      uses: actions/setup-python@v2
+      - name: Set up Python
+        uses: actions/setup-python@v2
 
-    - name: Print Python version
-      run: |
-        which python
-        which pip
-        python --version
+      - name: Print Python version
+        run: |
+          which python
+          which pip
+          python --version
 
-    - name: Print env
-      run: printenv
+      - name: Print env
+        run: printenv
 
-    - name: Checkout TileDB-Py `dev`
-      uses: actions/checkout@v2
+      - name: Checkout TileDB-Py `dev`
+        uses: actions/checkout@v2
 
-    - name: Install dependencies
-      run: python -m pip install --upgrade -r misc/requirements_ci.txt
+      - name: Install dependencies
+        run: python -m pip install --upgrade -r misc/requirements_ci.txt
 
-    - name: Test without pandas
-      run: python -m pip uninstall pandas
-      if: ${{ matrix.uninstall_pandas }} 
+      - name: Test without pandas
+        run: python -m pip uninstall -y pandas
+        if: ${{ matrix.uninstall_pandas }}
 
-    - name: Build TileDB-Py
-      run: |
-        python setup.py build_ext --inplace --werror
-        python setup.py install
+      - name: Build TileDB-Py
+        run: |
+          python setup.py build_ext --inplace --werror
+          python setup.py install
 
-    - name: Test TileDB-Py
-      run: pytest -vv
+      - name: Test TileDB-Py
+        run: pytest -vv
 
   create_issue_on_fail:
     runs-on: ubuntu-latest
     needs: test
     if: failure() || cancelled()
     steps:
-    - name: Checkout TileDB-Py `dev`
-      uses: actions/checkout@v2
-    - name: Create Issue if Build Fails
-      uses: JasonEtco/create-an-issue@v2
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        filename: .github/workflows/daily-test-build-issue-template.md
+      - name: Checkout TileDB-Py `dev`
+        uses: actions/checkout@v2
+      - name: Create Issue if Build Fails
+        uses: JasonEtco/create-an-issue@v2
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          filename: .github/workflows/daily-test-build-issue-template.md

tiledb/tests/test_examples.py

@@ -28,7 +28,7 @@ def test_examples(self, path):
         # - in tmpdir so we don't pollute the source tree
         # - with exit status checking (should fail tests if example fails)
         requires_pd = [
-            f"{self.PROJECT_DIR}/examples/{fn}.py"
+            os.path.join(self.PROJECT_DIR, "examples", f"{fn}.py")
             for fn in ["incomplete_iteration", "parallel_csv_ingestion"]
         ]
         if not has_pandas() and path in requires_pd: